Just sayin', fwiw...

Andrei Alexandrescu SeeWebsiteForEmail at erdani.org
Sat May 18 13:24:12 UTC 2019


On 5/17/19 7:48 PM, Jonathan M Davis wrote:
> On Friday, May 17, 2019 12:21:04 PM MDT H. S. Teoh via Digitalmars-d wrote:
>> On Thu, May 16, 2019 at 04:20:48PM -0400, Steven Schveighoffer via
> Digitalmars-d wrote:
>>> Refactoring would probably make sense, but not before you replace
>>> exactly the existing solution.
>>
>> [...]
>>
>> I'm tempted to submit a PR to unify toHash overloads like above. Would
>> it be accepted?
> 
> If you create a PR with much cleaner code that demonstrably does the same
> thing, then presumably, it would be accepted - especially since it's clear
> that we should be reducing the number of unnecessary overloads in general.

The union of overloads will have the OR of restrictions. The right 
unification will lead to simplification of said conditions. If we end up 
with a large disjunction then that's not progress.



More information about the Digitalmars-d mailing list