DIP 1028---Make @safe the Default---Community Review Round 1

[Steven Schveighoffer]

On 1/4/20 5:22 AM, WebFreak001 wrote:
> On Friday, 3 January 2020 at 22:36:17 UTC, Alex wrote:
>> [...]
>> Not sure, if this fits here. But if I add ´´´@safe:´´´ at the 
>> beginning of the module, the library 
>> https://code.dlang.org/packages/vebtree does not compile any more.
> 
> you can't just slap `@safe:` on because all the libraries and stuff you 
> depend on which wasn't marked @safe is still gonna stay @system and thus 
> disallow your calls. Instead you need to use the compiler with the @safe 
> by default PR.
> 
> I have done this for all dub packages now so everyone can review what 
> this change actually does to their packages:
> 
> https://i.webfreak.org/safe-test/index.html
> 
> It seems that your vebtree package compiles fine, however that is not to 
> say for the rest of dub. Currently a lot of issues are caused by phobos' 
> std.bitmanip.bitfields. So a lot of these errors are certainly fixable, 
> but currently it doesn't look good in terms of support. (Tested using 
> phobos v2.089.1-198-gbb8ba28bf)

Awesome! I'll look into the bitmanip problems.

Can you do us a favor and sort by package name?

-Steve