dub package PR social advice needed
bauss
jj_1337 at live.dk
Sun May 10 10:40:05 UTC 2020
On Saturday, 9 May 2020 at 11:55:36 UTC, evilrat wrote:
> Hi there,
> A few days back one guy opened PR for my old directx bindings,
> asking to merge patch for 68 files where he adds
> version(Windows) to these files, claiming that he has some
> problem using the package on non-Windows platforms (well,
> that's expected).
>
> While I don't consider this as a harmful I'm still somewhat
> skeptic about such changes that adds little to no value in my
> opinion.
> So instead I advised him to try using dub configurations for
> that task, and this where he start acting weird. Basically he
> just tell he don't care about any advises and then just quit...
>
> Well, ok then. But I still wanted to know what people think
> about such situations and hear advises on how to handle them.
> Should I just reject such stuff in the future, or "take down my
> proud" and merge? (though it's not about my proud tbh)
>
> One can read this little conversation here
> https://github.com/evilrat666/directx-d/pull/10
I partially agree with the PR.
Packages should work out of the box without additional project
configuration for platform etc.
Like for vibe.d you don't have to specify any platform specific
things in your configuration etc.
Platform dependencies should be handled in code and not in
configuration files.
What if a new package manager came along and it made the
assumption that things should work out of the box regardless of
platform?
What if someone wanted to use your package without dub and just
through dmd? There is no way to tell dmd the specification in an
easy way.
Of course it's your package and up to you but I see it as a red
flag when packages require extra configuration to be used on
specific platforms.
More information about the Digitalmars-d
mailing list