Walter knowingly, silently unfixed a bug

[ag0aep6g]

On 19.07.21 16:55, WebFreak001 wrote:
> in the last force push it seems the file was moved:
> 
> https://github.com/dlang/dmd/compare/9e598d64c076d8b8c2f79f0214cddf3d55f75e11...ab5a18635adaa3e2271e0f4b569500a89ac74235 

I'm not sure I know how to read these things, but it looks bad to me. 
AFAICT, this is the version that was reviewed:

https://github.com/dlang/dmd/commit/0b75c4567c012cc865d3e07ac50c08d59cca1800 
(2018-03-18T01:28:36Z)

fix17635.d was not touched in that version.

Jacob approved at 2018-03-18T11:36:52Z.

And this is the oldest version I can see that messes with fix17635.d:

https://github.com/dlang/dmd/commit/380ecff8fe281cff246b1b32c2e965a2691bd063 
(2018-03-19T21:40:04Z)

So it looks like Walter pushed non-trivial updates after the approval. 
And then he merged his own pull request based on the outdated approval.

> I haven't really thought about the content yet though, it might be that 
> this could actually be a more correct behavior, which might be why 
> Walter did this change.

It's not more correct. But even if it were, Walter would need to (1) 
explain that and (2) update the Bugzilla issue accordingly (mark invalid 
instead of fixed).