dmd git master version

[Steven Schveighoffer]

On 10/13/22 11:19 AM, H. S. Teoh wrote:
> On Thu, Oct 13, 2022 at 10:51:25AM -0400, Steven Schveighoffer via Digitalmars-d wrote:
>> On 10/13/22 12:16 AM, H. S. Teoh wrote:
>>> It's not so much the usage of git tags for release versioning that I
>>> find odd.  It's the fact that dmd 2.100.2 insists that it's 2.098,
>>> sets `__VERSION__` to 2098L, and believes that it's 2.098, yet the
>>> state of code is clearly already 2.100.2 and the compiler will
>>> behave like a 2.100.2 compiler.
>>
>> The build should double check the VERSION file against the tag, and
>> give an error when it doesn't match.
> 
> +1.

Looking at this monstrosity, I can't really understand why it's not 
writing the VERSION file anyway:

https://github.com/dlang/dmd/blob/61d7d56a0b82e049f45758bf3b4449fddda2cf96/compiler/src/build.d#L407-L446

Doesn't it seem like it compares the git tag to the text inside VERSION, 
and update VERSION if it's not the same?

-Steve