Please remove github workflow approval on dlang-community repositories
Johan
j at j.nl
Fri Feb 2 07:47:43 UTC 2024
Hi all,
We need to remove the github workflow approval [1] on
dlang-community repositories; workflow approval means: automatic
CI is not run on the PR until running CI (workflow) is approved.
I have firsthand experience that it is very demotivating, and I'm
sure it makes it less likely that contributors work on more
beyond a first PR.
I submitted a PR [2] for to dlang-community/setup-dlang. As
first-time contributor to that repository, apparently workflow
approval is needed. This means that for this rather simple
change, there is no immediate feedback of whether it is right or
wrong.
When hours later it got approved, it turned out there is a paren
`)` missing. Mathias kindly fixed it, so on waking up I now only
have to click a "commit" but to apply that suggestion, great!
Oh... not great... I now again need to wait for workflow approval
to learn whether it works or not..... If it's going to be like
that, it's just terribly annoying and demotivating.
I see no reason to disallow workflow approval unless there is
good evidence that there was spam in the recent past. Was there?
The link [1] has pointers to where this setting can be changed.
Thanks,
Johan
[1]
https://docs.github.com/en/actions/managing-workflow-runs/approving-workflow-runs-from-public-forks
[2] https://github.com/dlang-community/setup-dlang/pull/71
More information about the Digitalmars-d
mailing list