On Wed, Aug 17, 2011 at 10:41 PM, dsimcha <span dir="ltr"><<a href="mailto:dsimcha@yahoo.com">dsimcha@yahoo.com</a>></span> wrote:<br><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<div class="im">On 8/16/2011 7:48 AM, Jonas Drewsen wrote:<br>
</div><div><div></div><div class="h5"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hi all,<br>
<br>
This is a review request for the curl wrapper. Please read the "known<br>
issues" in the top of the source file and if possible suggest a solution.<br>
<br>
We also need somebody for running the review process. Anyone?<br>
<br>
Code:<br>
<a href="https://github.com/jcd/phobos/blob/curl-wrapper/etc/curl.d" target="_blank">https://github.com/jcd/phobos/<u></u>blob/curl-wrapper/etc/curl.d</a><br>
Docs:<br>
<a href="http://freeze.steamwinter.com/D/web/phobos/etc_curl.html" target="_blank">http://freeze.steamwinter.com/<u></u>D/web/phobos/etc_curl.html</a><br>
<br>
Demolish!<br>
<br>
/Jonas<br>
</blockquote>
<br></div></div>
One more comment: In various places, you have someFunction(in const(char)[] someString). Const and in are redundant. In is synonymous with const.<br>
<br>
Also, anyone have any luck getting Curl libs to work with DMD on Windows? The binaries available at <a href="http://curl.haxx.se/download.html" target="_blank">http://curl.haxx.se/download.<u></u>html</a> look like they're COFF. (<rant> Why do we still use freakin' OMF? </rant>) Also, the source doesn't look like it's pleasant to compile.<br>
</blockquote><div><br></div><div>I've always been using etc.c.curl on Windows. Use implib to generate .lib files from the dlls. </div></div><br>