[Dlang-internal] The Phantom Zone

Brad Roberts braddr at puremagic.com
Tue Jan 16 20:35:30 UTC 2018


On 1/16/2018 3:13 AM, Walter Bright via Dlang-internal wrote:
> On 1/15/2018 8:41 PM, Brad Roberts wrote:
>> What I'd like to see as a first step is to draw a line in the sand, 
>> every new pull request as of 1/1/2018 should be handled to resolution, 
>> period.  Don't let them get stale.
> 
> We've tried that again and again. It presupposes that all PRs have a 
> resolution. They do not - I mentioned 4 common reasons why in the 
> opening post.

They do, since closing with some tagging as a way to find them later is 
one of the possible resolutions, just as a last resort.

> There is another problem here. I just got back from POPL 2018 with a 
> list of ideas I want to get going on. I have made zero progress on any 
> of them, because I spend all the time reviewing other peoples' work, 
> dealing with can you please look at these bug reports, and one entire 
> evening rebasing PRs due to the torrent of refactorings.

Yup, pretty standard life of a senior developer.  I'm sure you're used 
to it.

> You're asking me to redouble my efforts at looking at PRs. It's just not 
> possible.

This isn't about you but rather the entire group of D developers.  I'm 
not sure how to effect the change, but imho, keeping the pull request 
queue clean needs to be higher priority than producing additional pulls. 
  It's not that the bug fixing, code cleanup, new features, etc aren't 
important, but that they're one step behind making sure existing hard 
work is appreciated and followed through on.  Every single place I've 
ever worked getting code reviewed and checked in has taken precedence 
over writing new code.

----

I guess I should ask a question:  What's your goal with the PZ?  Is it 
to have the github pull queues kept to a tiny number of open and active 
requests?

Great, that's exactly what I just suggested with the primary difference 
being just focusing on the ones from the start of the year as a trial 
run before applying the same policies to the rest of the queue.

If not, then what is the goal and what's the differences that you envision?


More information about the Dlang-internal mailing list