[Dlang-internal] Potential changes to DDoc

[David Gileadi]

On 1/22/18 6:50 PM, Sebastian Wilzbach wrote:
> David, thanks a lot for championing this project and pushing it forward!
> I saw that you already joined Slack and #dmd, so please feel free to ask 
> questions there.
> 
> There are two advises I can give you that as they will save you a lot of 
> frustration and work:
> 
>> Open your PR early
> 
> Most discussions happen either on GitHub or Slack.
> As not everyone is active on Slack, a GitHub PR is usually a good place 
> for a in-depth conversation.
> Also looking at your work allows us to give you feedback early on and 
> avoid unnecessary work / it drifting in the wrong direction.

Thanks for the advice. I went ahead and create a PR [1].

I'd been avoiding a PR because I've been rebasing my changes on master 
rather than merging, and I didn't want to cause confusion by rewriting 
history. Should I switch to merging changes from master now that I 
created a PR?

>> Split your changes into minimal chunks
> 
> Ideally each point on your TODO list translates to one small PR.
> This allows fast review and as a bonus avoids rebasing conflicts.
> This point is usually underestimated, but it's vastly easier to pull a 
> 30 lines change (+tests) than a 1K diff.

I haven't managed to do that so far, but it may be possible to do so 
after the fact.


[1] https://github.com/dlang/dmd/pull/7764