[dmd-internals] DVCS and patches feedback [was: dmd commit, revision 515]

[Simen Kjaeraas]

Don Clugston <dclugston at googlemail.com> wrote:

> This shows a significant misunderstanding of where the time goes.
> There are three things that take a lot of time: (1) understanding the
> bug, and how the patch is trying to fix it;  (2) running the test
> suite (takes about half an hour); (3) adding the bug to the test
> suite.

3) Could be ameliorated by having a known folder for the test suite,
and pull contents to that as well.

> You've also missed the steps of reproducing the existing bug, and
> checking that the bug now passes. This always involves copying code
> from bugzilla into a text editor.

See above. Any bug could have an associated test file.

Both of these ideas place the onus of patching on the patcher, not
on Walter. Of course, both would require a naming standard and
possibly further information on the details.

-- 
Simen