[dmd-internals] DVCS and patches feedback [was: dmd commit, revision 515]

[Leandro Lucarella]

Walter Bright, el  3 de junio a las 14:16 me escribiste:
> Don Clugston wrote:
> >This shows a significant misunderstanding of where the time goes.
> >There are three things that take a lot of time: (1) understanding the
> >bug, and how the patch is trying to fix it;  (2) running the test
> >suite (takes about half an hour); (3) adding the bug to the test
> >suite.
> >Making the changes to the existing code is usually (though not always)
> >pretty trivial and quick. The majority of the patches which I have
> >made are just one-line or two-line changes.
> >
> >You've also missed the steps of reproducing the existing bug, and
> >checking that the bug now passes. This always involves copying code
> >from bugzilla into a text editor.
> >
> >It should be pretty clear from this that (2) and (3) have some major
> >opportunities for efficiency improvement. Far more significant IMHO
> >than any changes to the compiler version control system.
> >
> 
> A couple more things need to happen:
> 
> 4. have to fold it into D1, or if it's a D1 patch, fold it into D2
> 5. update change logs, bugzilla resolution messages

And that is (or should be) part of making the patch too, not merging it.
If patches are not good or complete enough, you should give people
feedback and tell them what to change to make a quality and complete
patch, not fix the patch for them. If you do that, people will not learn
and you will work much more than you should, as it happened when the
back-end source was not available. I hope sometime in the future you can
see that.

-- 
Leandro Lucarella (AKA luca)                     http://llucax.com.ar/
----------------------------------------------------------------------
GPG Key: 5F5A8D05 (F8CD F9A7 BF00 5431 4145  104C 949E BFB6 5F5A 8D05)
----------------------------------------------------------------------
3 people die every year, testing if a 9 volts battery works on their tongue