[dmd-internals] Fw: [D-Programming-Language/dmd] fc0bbd: merge D2 pull 348

[Steve Schveighoffer]

gah, sorry, meant for this to go to the list.

-Steve



----- Forwarded Message -----
> From: Steve Schveighoffer <schveiguy at yahoo.com>
> To: Daniel Murphy <yebblies at gmail.com>
> Cc: 
> Sent: Wednesday, August 31, 2011 10:03 AM
> Subject: Re: [dmd-internals] [D-Programming-Language/dmd] fc0bbd: merge D2 pull 348
> 
> You are right.  I see the other merges that have the valid data.
> 
> My mail client happened to cut off that last comment line so I wasn't seeing 
> them without scrolling, and when I did happen to scroll it was on one of these 
> D1 merges.
> 
> 
> Sorry for the noise.
> 
> -Steve
> 
> 
> 
> ----- Original Message -----
>>  From: Daniel Murphy <yebblies at gmail.com>
>>  To: Steve Schveighoffer <schveiguy at yahoo.com>; Discuss the internals 
> of DMD <dmd-internals at puremagic.com>
>>  Cc: 
>>  Sent: Wednesday, August 31, 2011 9:48 AM
>>  Subject: Re: [dmd-internals] [D-Programming-Language/dmd] fc0bbd: merge D2 
> pull 348
>> 
>> T hese are merges to D1, not just straight merges of pull requests.
>> 
>>  On Wed, Aug 31, 2011 at 9:17 PM, Steve Schveighoffer
>>  <schveiguy at yahoo.com> wrote:
>>>   I'm not sure if this is something to do with github configuration 
> for 
>>  dmd, but when I merge pull requests for druntime or phobos:
>>> 
>>>   1. The default message is the description of the pull request
>>>   2. I see more commits in the mailing list than just "merging pull 
> 
>>  xyz"
>>> 
>>>   These messages are pretty much useless.  "Merge D2 pull 348" 
> 
>>  gives me absolutely no information.  I have to go to github, find the pull 
>>  request itself, and look at the comment for the pull request, in this 
> case:  
>>  Issue 5953 - Too many trailing commas are accepted
>>> 
>>>   Why doesn't the commit message reflect the description of the pull 
> 
>>  request?
>>> 
>>>   -Steve
>>> 
>>>>  ________________________________
>>>>  From: "noreply at github.com" <noreply at github.com>
>>>>  To: dmd-internals at puremagic.com
>>>>  Sent: Wednesday, August 31, 2011 3:35 AM
>>>>  Subject: [dmd-internals] [D-Programming-Language/dmd] fc0bbd: merge 
> D2 
>>  pull 348
>>>> 
>>>>    Branch: refs/heads/dmd-1.x
>>>>    Home:  https://github.com/D-Programming-Language/dmd
>>>> 
>>>>    Commit: fc0bbd3afba6e5f878fecc8a029f437b1df51e41
>>>>        
>> 
> https://github.com/D-Programming-Language/dmd/commit/fc0bbd3afba6e5f878fecc8a029f437b1df51e41
>>>>    Author: Walter Bright <walter at walterbright.com>
>>>>    Date:   2011-08-31 (Wed, 31 Aug 2011)
>>>> 
>>>>    Changed paths:
>>>>      M src/parse.c
>>>> 
>>>>    Log Message:
>>>>    -----------
>>>>    merge D2 pull 348
>>>> 
>>>> 
>>>>  _______________________________________________
>>>>  dmd-internals mailing list
>>>>  dmd-internals at puremagic.com
>>>>  http://lists.puremagic.com/mailman/listinfo/dmd-internals
>>>> 
>>>> 
>>>> 
>>>   _______________________________________________
>>>   dmd-internals mailing list
>>>   dmd-internals at puremagic.com
>>>   http://lists.puremagic.com/mailman/listinfo/dmd-internals
>>> 
>> 
>