[dmd-internals] generating pull requests for DMD

Don Clugston dclugston at googlemail.com
Sun May 29 12:37:49 PDT 2011


My personal experience:
I run the test suite with only two combinations: no flags, and with -O
-inline -release.  It's only very obscure bugs that aren't detected
with one of those two (personally I've never encountered one, although
I believe they do exist; but failures which are OS-specific are more
common by at least a factor of ten). It takes three minutes to run,
and Phobos takes about two minutes. So it really should not be painful
to run the tests.

If people are not running the tests because they are finding it
difficult or unpleasant, we need to work out why, and fix the problem.
Please speak up!

-Don.

On 29 May 2011 20:13, Walter Bright <walter at digitalmars.com> wrote:
> For those doing compiler patches, I know it's a tough job, and thanks!
>
> But please consider running the dmd test suite (and try to build/run phobos
> unittests) before issuing a pull request. There are a lot of
> interdependencies in the compiler, and the test suite is designed to flush
> them out. The cool thing is the test suite consists of cases that are
> already minimized! The suite also is designed to not take that long to run.
>
> I run it constantly when I do dev on the compiler, and I constantly get
> dinged by it for something I overlooked. I consider the D test suite to be a
> major asset for us.
>
> Please use it. If you've got problems using it, please post here and we'll
> try to help.
> _______________________________________________
> dmd-internals mailing list
> dmd-internals at puremagic.com
> http://lists.puremagic.com/mailman/listinfo/dmd-internals
>


More information about the dmd-internals mailing list