[dmd-internals] What is the necessary to increase speed of merging?

[kenji hara]

I basically *always* run test suites (dmd, druntime, and Phobos) with
my patch first in my local PC (Windows), and then post it as a pull
request.
But, unfortunately, to maintain this process is much difficult than a year ago.

I think there are three levels in my pulls .
Level 1. many trivial patches
   Type decoding bug, AST processing bug, ... (almost of them are
front-end issues)
Level 2. some bigger pulls
   relax opAssign signature, rvalue-struct-literal, object not const
correct, opDispatch and IFTI bug, auto return function with
contracts...
Level 3. few enhancements
   Multiple var declaration, typeof(null)

I believe that the level 1 pulls should merged as soon as possible.

Kenji Hara

2011/11/12 Walter Bright <walter at digitalmars.com>:
>
>
> On 11/11/2011 9:18 AM, kenji hara wrote:
>>
>> To Walter
>>
>> I have posted 130 pulls on github in a year, but about forty ones are
>> still opened.
>
> At the moment, I haven't been doing pulling because I'm working on the 64
> bit OSX port. When I get that under control, it's back to pulling.
>
>> I'd like to increase speed of merging, but I don't know the way to realize
>> it.
>> What is the necessary?
>>
>> - D1 patch?
>>   Today only Walter improvements D1 branch. Almost dmd pulls only
>> consider D2 branch. Should we add D1 patch at the same time?
>
> Merging with D1 hasn't been too difficult; I use a program called "meld"
> which makes it a snap.
>
>> - Reviewing?
>>   Almost dmd pulls doesn't have been reviewed by other dmd commiters.
>
> Not many are that familiar with the internal design.
>
>> - Conflicting?
>>   Almost patches uses runnable/xtest46.d, template9.d, aliasthis.d
>> for test suite. This fact has introduced conflicts between the
>> patches. I sometimes rebases my many pulls, but the cost of doing it
>> is much more.
>
> If you want, you can start a new test.d.
>
>> - Others?
>> ???
>
> It usually takes a couple hours to merge a patch, if things go smoothly.
> Most of that is running the test suite. Some more time is spent updating the
> changelog and bugzilla.
>
>> Please answer this question, Walter. I'd like to improve the bottleneck.
>
> I'd like to compliment you on how prolific, helpful, and correct your
> patches have been. Thanks!
> _______________________________________________
> dmd-internals mailing list
> dmd-internals at puremagic.com
> http://lists.puremagic.com/mailman/listinfo/dmd-internals
>