[dmd-internals] [D-Programming-Language/dmd] 02ff41: Added comment for pull request #364 fix.

noreply at github.com noreply at github.com
Thu Sep 15 15:51:45 PDT 2011


  Branch: refs/heads/master
  Home:   https://github.com/D-Programming-Language/dmd

  Commit: 02ff41f1503fc40f92e12f8ad03b7332ec56f60c
      https://github.com/D-Programming-Language/dmd/commit/02ff41f1503fc40f92e12f8ad03b7332ec56f60c
  Author: David Nadlinger <code at klickverbot.at>
  Date:   2011-09-15 (Thu, 15 Sep 2011)

  Changed paths:
    M src/template.c

  Log Message:
  -----------
  Added comment for pull request #364 fix.

As Don requested, documented the assumption that the stored index is still valid and added an assert() checking that.

If this assert ever triggers, I was wrong and the position of 'this' among the Dsymbols indeed has to be looked up again.


  Commit: 1da648e04b24844076997a4f13aa38cd1d4eb45c
      https://github.com/D-Programming-Language/dmd/commit/1da648e04b24844076997a4f13aa38cd1d4eb45c
  Author: David Nadlinger <code at klickverbot.at>
  Date:   2011-09-15 (Thu, 15 Sep 2011)

  Changed paths:
    M src/parse.c

  Log Message:
  -----------
  Fixed conflicting attribute error message.

Previously, composeStorageClass was only invoked when parsing the list of postfix specifications has been finished, so the error message referred to the opening brace instead of the attribute in question:

For example, »void foo() @safe @system {}« would previously give »conflicting attribute @{« instead of »conflicting attribute @system«

No test case, because this commit improves an error message only.


  Commit: e86b7b769a1efdb3ebe65d8eb963c6f1b18a4316
      https://github.com/D-Programming-Language/dmd/commit/e86b7b769a1efdb3ebe65d8eb963c6f1b18a4316
  Author: Walter Bright <walter at walterbright.com>
  Date:   2011-09-15 (Thu, 15 Sep 2011)

  Changed paths:
    M src/parse.c
  M src/template.c

  Log Message:
  -----------
  Merge pull request #384 from klickverbot/conflicting-attribute-msg

Fixed conflicting attribute error message.


Compare: https://github.com/D-Programming-Language/dmd/compare/5275774...e86b7b7


More information about the dmd-internals mailing list