[dmd-internals] [D-Programming-Language/dmd] 2958fb: struct literals are lvalues again

kenji hara k.hara.pg at gmail.com
Wed Apr 11 20:41:49 PDT 2012


Phobos already has some overloads for rvalue, it is merged in 78591b90aa.

But your change reverts bug 5889 and make ref/non-ref struct overload
ambiguous, and beta6 user will see that error. Then Phobos is silently
broken now.

Kenji Hara

2012年4月12日11:52 Walter Bright <walter at digitalmars.com>:
> Sure, but in 2.057 the library wasn't broken, either. While there may be
> problems with it, I don't think these should hold up the release, as those have
> always been there.
>
> On 4/11/2012 7:19 PM, kenji hara wrote:
>> We didn't add tests into druntime and Phobos for ref/non-ref overloads.
>> So there is no tests should be broken in libraries with your changes.
>>
>> Kenji Hara
>>
>> 2012年4月12日11:07 Walter Bright <walter at digitalmars.com>:
>>> All the library tests pass.
>>>
>>>
>>> On 4/11/2012 6:39 PM, kenji hara wrote:
>>>> I think this is too straightforward change.
>>>> I believe that druntime and phobos are broken silently with this.
>>>>
>>>> I'm trying to implement rvalue struct literal that can receives with ref.
>>>> It does not seem so difficult.
>>>> Please wait the release a moment.
>>>>
>>>> Kenji Hara
>>>>
>>> _______________________________________________
>>> dmd-internals mailing list
>>> dmd-internals at puremagic.com
>>> http://lists.puremagic.com/mailman/listinfo/dmd-internals
>> _______________________________________________
>> dmd-internals mailing list
>> dmd-internals at puremagic.com
>> http://lists.puremagic.com/mailman/listinfo/dmd-internals
>>
>>
> _______________________________________________
> dmd-internals mailing list
> dmd-internals at puremagic.com
> http://lists.puremagic.com/mailman/listinfo/dmd-internals


More information about the dmd-internals mailing list