[dmd-internals] [D-Programming-Language/dmd] eaac7b: fix build breakage

Rainer Schuetze r.sagitario at gmx.de
Tue Feb 28 00:41:49 PST 2012


Thanks for merging in the vcbuild patch.

I guess this commit was made to fix building dmc, but it broke the MS 
build at 2 places. I have prepared a pull request, but wanted to ask 
what the right way to fix them is:

On 25.02.2012 03:47, GitHub wrote:
>    Branch: refs/heads/master
>    Home:   https://github.com/D-Programming-Language/dmd
>    Commit: eaac7ba53fc1f913120693b2c8bca4d22574fa7e
>        https://github.com/D-Programming-Language/dmd/commit/eaac7ba53fc1f913120693b2c8bca4d22574fa7e
>    Author: Walter Bright<walter at walterbright.com>
>    Date:   2012-02-24 (Fri, 24 Feb 2012)
>
>    Changed paths:
>      M src/backend/bcomplex.h
>    M src/backend/cc.h
>    M src/backend/cdef.h

this line was reverted:

+inline char *prettyident(Symbol *s) { return CPP ? cpp_prettyident(s) : s->Sident; }


but it causes a link failure due to missing symbol cpp_prettyident. 
Where should I put its implementation? dsymbol.c? Maybe it should be 
added to the D source unconditionally, not only for _MSC_VER.

>    M src/backend/cg87.c

reverted the use of longdouble. If I read the includes correctly, it 
should be defined in cdef.h for a C compiler aswell. Why should it not 
be used?

>    M src/backend/debug.c
>    M src/backend/el.c
>    M src/posix.mak
>    M src/root/longdouble.c
>    M src/root/longdouble.h
>    M src/win32.mak
>
>    Log Message:
>    -----------
>    fix build breakage
>
>
>
>
>
> _______________________________________________
> dmd-internals mailing list
> dmd-internals at puremagic.com
> http://lists.puremagic.com/mailman/listinfo/dmd-internals

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.puremagic.com/pipermail/dmd-internals/attachments/20120228/928aaab8/attachment.html>


More information about the dmd-internals mailing list