[dmd-internals] [D-Programming-Language/dmd] 10640a: dang, forgot that one, too

Leandro Lucarella luca at llucax.com.ar
Tue Nov 6 15:59:59 PST 2012


Jacob Carlborg, el  6 de November a las 20:56 me escribiste:
> 
> On 6 nov 2012, at 16:44, GitHub <noreply at github.com> wrote:
> 
> >  Branch: refs/heads/master
> >  Home:   https://github.com/D-Programming-Language/dmd
> >  Commit: 10640a73130a7d6802d1e72da9e3b45af065f512
> >      https://github.com/D-Programming-Language/dmd/commit/10640a73130a7d6802d1e72da9e3b45af065f512
> >  Author: Walter Bright <walter at walterbright.com>
> >  Date:   2012-11-06 (Tue, 06 Nov 2012)
> > 
> >  Changed paths:
> >    M src/backend/cv8.c
> > 
> >  Log Message:
> >  -----------
> >  dang, forgot that one, too
> 
> I don't know how your workflow with git is. But I usually just make the changes I want and then commit them with this command:
> 
> $ git commit -a -m "Message"
> 
> The "-a" flag will include all changes in all files tracked by git. It won't add any new files.

Also, it could be a good idea to avoid compulsive commits and using the
autotester. If a commit is broken, you can always fix it by making the
appropriate changes and doing a git commit --amend -a to fix the commit and
void these useless commits of "I forgot yada". This will also not break git
bisect.

You can even fix an older commit by using git rebase -i. Of course you should
only amend commits that are not in the official repo.

Also, following the pull request path as everybody else could prevent a lot of
these kind of errors while committing. Maybe you should consider doing that, at
least to ensure all your commits pass the tests.

-- 


More information about the dmd-internals mailing list