[dmd-internals] So about the whole pull request thing

David Nadlinger code at klickverbot.at
Tue Oct 2 12:43:40 PDT 2012


On Tue, Oct 2, 2012 at 5:24 PM, Andrei Alexandrescu <andrei at erdani.com> wrote:
> The only reason I haven't suggested migrating to Phabricator yet is I didn't
> want to stir things once again too early. But if use of github reviews is
> painful, we definitely should look at Phabricator.

I could also imagine using Phabricator – while I have not used it
extensively yet, it looked like it has clever solutions for a few
problems when I played around with it some while ago.

However, let's not forget that GitHub has worked pretty darn well for
us so far. Yes, we obviously wouldn't have a pile of open pull
requests if it were not for GitHub, but then, we'd probably only get
something like 1/4 of the contributions, and half of them would be
bitrotting as badly reviewed patches attached to some Bugzilla ticket.

What I am saying is that we should be very clear about in which areas
Phabricator would provide a definite advantage compared to the current
situation, and if it is enough to outweigh the possible negative
consequences of switching away from GitHub – both in order to make a
good decision in the first place, and then to have a good answer to
the inevitable »But why on earth would we want to do that«-type
questions in the aftermath.

David


More information about the dmd-internals mailing list