[dmd-internals] [D-Programming-Language/dmd] e81802: forgot code.h

[Brad Roberts]

On 1/6/2013 5:45 PM, Walter Bright wrote:
> 
> On 1/6/2013 5:08 PM, Jonathan M Davis wrote:
>> Even if you were merging all of your pull requests for dmd yourself rather than waiting for reviews like everyone else
>> does, by using pull requests, you'd at least avoid breaking the build due to forgetting to commit everything, and
>> you'd get your changes tested on all of our platforms by the pull tester. I don't see any reason for you not to do at
>> least do that much, and I thought that that's what you had previously agreed to start doing.
> 
> I did agree to the release process, which is what we did.
> 
> I do several commits a day, this easily moves into hundreds for each cycle. Is anyone going to review them?

1) # commits != # pulls

2) I look at nearly every one of them already, though most I don't feel qualified to comment on.

3) There's more value to pull requests than just human review, the auto-tester adds value too.