[dmd-internals] [D-Programming-Language/dmd] b7866e: Fix bogus zero-length array test.

GitHub via dmd-internals dmd-internals at puremagic.com
Mon Sep 15 00:23:15 PDT 2014


  Branch: refs/heads/master
  Home:   https://github.com/D-Programming-Language/dmd
  Commit: b7866eff1567e5dfdf0e28e99d6cb3515d273854
      https://github.com/D-Programming-Language/dmd/commit/b7866eff1567e5dfdf0e28e99d6cb3515d273854
  Author: David Nadlinger <code at klickverbot.at>
  Date:   2014-07-08 (Tue, 08 Jul 2014)

  Changed paths:
    M test/runnable/xtest46.d

  Log Message:
  -----------
  Fix bogus zero-length array test.

Issue 7175 was about .ptr always giving null for a zero-length
static array in a struct, despite the fact that the struct has
size 1 and thus certainly a non-null address.

The test case as modified by 36c9b64, however, checks that a
free-standing zero-length static array on the stack has an
address, which is quite a different scenario. From the spec,
I don't see a reason why zero-sized objects should need any
memory associated with them, so I am reluctant to pessimize
LDC's codegen over this.


  Commit: bccee0f09bc27d79af9b3d7d420ad898f908ffcb
      https://github.com/D-Programming-Language/dmd/commit/bccee0f09bc27d79af9b3d7d420ad898f908ffcb
  Author: Hara Kenji <k.hara.pg+dev at gmail.com>
  Date:   2014-09-15 (Mon, 15 Sep 2014)

  Changed paths:
    M test/runnable/xtest46.d

  Log Message:
  -----------
  Merge pull request #3729 from klickverbot/fix-7175-test

Fix bogus zero-length array test.


Compare: https://github.com/D-Programming-Language/dmd/compare/82925bccfb37...bccee0f09bc2


More information about the dmd-internals mailing list