[dmd-internals] [D-Programming-Language/dmd] a5ec25: [Fix] Fix static asserts in `test/compilable/testf...

GitHub via dmd-internals dmd-internals at puremagic.com
Wed Apr 1 04:56:16 PDT 2015


  Branch: refs/heads/master
  Home:   https://github.com/D-Programming-Language/dmd
  Commit: a5ec2526cbbcd912e203c04bcbcbec222bbfbc45
      https://github.com/D-Programming-Language/dmd/commit/a5ec2526cbbcd912e203c04bcbcbec222bbfbc45
  Author: Denis Shelomovskij <verylonglogin.reg at gmail.com>
  Date:   2015-04-01 (Wed, 01 Apr 2015)

  Changed paths:
    M test/compilable/testfwdref.d

  Log Message:
  -----------
  [Fix] Fix static asserts in `test/compilable/testfwdref.d`.

These asserts erroneously used `static assert("a = ", a == b);` pattern which always passes.

Also it shouldn't be rewritten using comma expression as in such case compiler will write `("a = " , false)` which is less informative than `<value> == <expected value>` message.

Causing commit: 8efa502a209c64a75f682956cab0b3647737c614.


  Commit: e89a2b2f9b5c3b05edc71e83f3ca6ff9c7c3acb0
      https://github.com/D-Programming-Language/dmd/commit/e89a2b2f9b5c3b05edc71e83f3ca6ff9c7c3acb0
  Author: Denis Shelomovskij <verylonglogin.reg at gmail.com>
  Date:   2015-04-01 (Wed, 01 Apr 2015)

  Changed paths:
    M test/compilable/testfwdref.d

  Log Message:
  -----------
  [Refactor] Remove redundant parentheses around `int`.


  Commit: 302d42186a30452ddb0c7bd02f4f8c682a8f4c93
      https://github.com/D-Programming-Language/dmd/commit/302d42186a30452ddb0c7bd02f4f8c682a8f4c93
  Author: Denis Shelomovskij <verylonglogin.reg at gmail.com>
  Date:   2015-04-01 (Wed, 01 Apr 2015)

  Changed paths:
    M test/compilable/testfwdref.d

  Log Message:
  -----------
  [Fix] Fix incorrect test for issue 12984.

Causing commit: 8efa502a209c64a75f682956cab0b3647737c614.


  Commit: b17de5d448da2eb4ae34ca9e60f500aab004c2ba
      https://github.com/D-Programming-Language/dmd/commit/b17de5d448da2eb4ae34ca9e60f500aab004c2ba
  Author: Hara Kenji <k.hara.pg+dev at gmail.com>
  Date:   2015-04-01 (Wed, 01 Apr 2015)

  Changed paths:
    M test/compilable/testfwdref.d

  Log Message:
  -----------
  Merge pull request #4538 from denis-sh/fixup-pull-4537

Fixup pull 4537


Compare: https://github.com/D-Programming-Language/dmd/compare/23222409dd4f...b17de5d448da


More information about the dmd-internals mailing list