[dmd-internals] [D-Programming-Language/dmd] 97b4ec: Remove WANTflags

GitHub via dmd-internals dmd-internals at puremagic.com
Tue Jan 13 23:11:00 PST 2015


  Branch: refs/heads/master
  Home:   https://github.com/D-Programming-Language/dmd
  Commit: 97b4eca67275f2e562af5207c7c703d859b989a6
      https://github.com/D-Programming-Language/dmd/commit/97b4eca67275f2e562af5207c7c703d859b989a6
  Author: k-hara <k.hara.pg at gmail.com>
  Date:   2015-01-14 (Wed, 14 Jan 2015)

  Changed paths:
    M src/cast.c
    M src/expression.c
    M src/expression.h
    M src/optimize.c
    M src/statement.c
    M test/compilable/extra-files/json.out

  Log Message:
  -----------
  Remove WANTflags

It meant to remove straitforward class upcast C to B (offset == 0), and
used where a compile-time boolean value required.

I couldn't think any problematic case that will be introduced by the constantly enabling the optimization.


  Commit: d76bcaabe2d8275adece75f93ade9cfed0dab790
      https://github.com/D-Programming-Language/dmd/commit/d76bcaabe2d8275adece75f93ade9cfed0dab790
  Author: k-hara <k.hara.pg at gmail.com>
  Date:   2015-01-14 (Wed, 14 Jan 2015)

  Changed paths:
    M src/expression.c
    M src/expression.h
    M src/interpret.c
    M src/optimize.c
    M src/statement.c
    M src/staticassert.c

  Log Message:
  -----------
  Make WANTvalue default

The difference 0 and WANTvalue was used in AndAndExp/OrOrExp to make error for the void expressions if value is required.

But today, the appearance of invalid void sub-expression is structly checked by Expresssion::rvalue() etc in each semantic() calls, so the check in optimize() is unnecessary.

Therefore, change the value of WANTvalue to 0 and make that the default behavior of optimize().


  Commit: d9d4ffaf63f00c210989f298e24a819f3c0cfbe2
      https://github.com/D-Programming-Language/dmd/commit/d9d4ffaf63f00c210989f298e24a819f3c0cfbe2
  Author: k-hara <k.hara.pg at gmail.com>
  Date:   2015-01-14 (Wed, 14 Jan 2015)

  Changed paths:
    M src/expression.h

  Log Message:
  -----------
  Change WANTexpand value to 1


  Commit: 25058990fe6597810b559b37b04eda93081d70da
      https://github.com/D-Programming-Language/dmd/commit/25058990fe6597810b559b37b04eda93081d70da
  Author: k-hara <k.hara.pg at gmail.com>
  Date:   2015-01-14 (Wed, 14 Jan 2015)

  Changed paths:
    M src/optimize.c

  Log Message:
  -----------
  Tweak indent style


  Commit: 6c68edc8db4cf14cc17e321a0ba2e88635d497ba
      https://github.com/D-Programming-Language/dmd/commit/6c68edc8db4cf14cc17e321a0ba2e88635d497ba
  Author: Walter Bright <walter at walterbright.com>
  Date:   2015-01-13 (Tue, 13 Jan 2015)

  Changed paths:
    M src/cast.c
    M src/expression.c
    M src/expression.h
    M src/interpret.c
    M src/optimize.c
    M src/statement.c
    M src/staticassert.c
    M test/compilable/extra-files/json.out

  Log Message:
  -----------
  Merge pull request #4296 from 9rnsr/refactor_optimizer

Refactor optimizer


Compare: https://github.com/D-Programming-Language/dmd/compare/6c6e123f6f6e...6c68edc8db4c


More information about the dmd-internals mailing list