[dmd-internals] Module.semantic is not virtual

[Johan Engelen via dmd-internals]

Hi all,
  Class Module contains the member functions semantic(), semantic2, and
semantic3() that are not virtual. They have the same name however as the
Dsymbol virtual methods. Because Module inherits from Dsymbol, it is
confusing to reuse the names. Clang warns about Module's functions hiding
the virtual methods of the parent class.

What was the intent here? Should Module's semantic functions override the
base class's functions (but then why the *final* Package::semantic()?), or
should they be separate function and just be renamed to something more
clear?

thanks,
  Johan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.puremagic.com/pipermail/dmd-internals/attachments/20160727/54eb2902/attachment.html>