<html><body><div>I think we should create a "Contribute" page on the Digitalmars site and the d-programming-language.org site.<br><br>On 29 May, 2011,at 10:53 PM, Robert Clipsham <robert@octarineparrot.com> wrote:<br><br></div><div><blockquote type="cite"><div class="msg-quote">On 29 May 2011 19:13, Walter Bright <span dir="ltr"><<a href="mailto:walter@digitalmars.com" _mce_href="mailto:walter@digitalmars.com">walter@digitalmars.com</a>></span> wrote:<br><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;" _mce_style="margin: 0 0 0 .8ex; border-left: 1px #ccc solid; padding-left: 1ex;">
For those doing compiler patches, I know it's a tough job, and thanks!<br>
<br>
But please consider running the dmd test suite (and try to build/run phobos unittests) before issuing a pull request. There are a lot of interdependencies in the compiler, and the test suite is designed to flush them out. The cool thing is the test suite consists of cases that are already minimized! The suite also is designed to not take that long to run.<br>
<br>
I run it constantly when I do dev on the compiler, and I constantly get dinged by it for something I overlooked. I consider the D test suite to be a major asset for us.<br>
<br>
Please use it. If you've got problems using it, please post here and we'll try to help.<br></blockquote><div><br></div><div>I advise you add a README.md to the root of the dmd repository with contents looking something like:</div>
<div>----</div><div># DigitalMars D Compiler and Test Suite</div><div><br></div><div>Compiler and test suite for the D programming language - <a href="http://d-programming-language.org/" _mce_href="http://d-programming-language.org/">http://d-programming-language.org/</a></div>
<div><br></div><div>## Building</div><div><br></div><div>Replace $OS with windows, linux, osx, freebsd, solaris or openbsd depending on your operating system.</div><div><br></div><div> cd src</div><div> make -f $OS.mak</div>
<div><br></div><div>## Pull Requests</div><div><br></div><div>When creating pull requests, please make sure to run the test suite before! Even if it's a small change and you think it's not needed - you'd be surprised what a small change can break!</div>
<div><br></div><div>## Running the test suite</div><div><br></div><div>I actually don't know how to do this, but some instructions should go here. Also take a look at <a href="http://github.github.com/github-flavored-markdown/" _mce_href="http://github.github.com/github-flavored-markdown/">http://github.github.com/github-flavored-markdown/</a> for information on formatting in this file.</div>
<div>----</div><div><br></div><div>I could clean this up and make a pull request if you're interested? ;) </div><div><br></div></div>-- <br>Robert<br><a href="http://octarineparrot.com/" _mce_href="http://octarineparrot.com/">http://octarineparrot.com/</a><br>
<div class="_stretch">_______________________________________________<br>
dmd-internals mailing list<br>
<a href="mailto:dmd-internals@puremagic.com" _mce_href="mailto:dmd-internals@puremagic.com">dmd-internals@puremagic.com</a><br>
<a href="http://lists.puremagic.com/mailman/listinfo/dmd-internals" _mce_href="http://lists.puremagic.com/mailman/listinfo/dmd-internals">http://lists.puremagic.com/mailman/listinfo/dmd-internals</a></div></div></blockquote></div></body></html>