<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Thanks for merging in the vcbuild patch.<br>
<br>
I guess this commit was made to fix building dmc, but it broke the
MS build at 2 places. I have prepared a pull request, but wanted to
ask what the right way to fix them is:<br>
<br>
On 25.02.2012 03:47, GitHub wrote:
<blockquote
cite="mid:4f484bcc1e4de_2d353fa15d6dfaf48121e@sh1.rs.github.com.mail"
type="cite">
<pre wrap=""> Branch: refs/heads/master
Home: <a class="moz-txt-link-freetext" href="https://github.com/D-Programming-Language/dmd">https://github.com/D-Programming-Language/dmd</a>
Commit: eaac7ba53fc1f913120693b2c8bca4d22574fa7e
<a class="moz-txt-link-freetext" href="https://github.com/D-Programming-Language/dmd/commit/eaac7ba53fc1f913120693b2c8bca4d22574fa7e">https://github.com/D-Programming-Language/dmd/commit/eaac7ba53fc1f913120693b2c8bca4d22574fa7e</a>
Author: Walter Bright <a class="moz-txt-link-rfc2396E" href="mailto:walter@walterbright.com"><walter@walterbright.com></a>
Date: 2012-02-24 (Fri, 24 Feb 2012)
Changed paths:
M src/backend/bcomplex.h
M src/backend/cc.h
M src/backend/cdef.h</pre>
</blockquote>
<br>
this line was reverted:<br>
<pre>+inline char *prettyident(Symbol *s) { return CPP ? cpp_prettyident(s) : s->Sident; }</pre>
<br>
but it causes a link failure due to missing symbol cpp_prettyident.
Where should I put its implementation? dsymbol.c? Maybe it should be
added to the D source unconditionally, not only for _MSC_VER.<br>
<br>
<blockquote
cite="mid:4f484bcc1e4de_2d353fa15d6dfaf48121e@sh1.rs.github.com.mail"
type="cite">
<pre wrap="">
M src/backend/cg87.c</pre>
</blockquote>
<br>
reverted the use of longdouble. If I read the includes correctly, it
should be defined in cdef.h for a C compiler aswell. Why should it
not be used?<br>
<br>
<blockquote
cite="mid:4f484bcc1e4de_2d353fa15d6dfaf48121e@sh1.rs.github.com.mail"
type="cite">
<pre wrap="">
M src/backend/debug.c
M src/backend/el.c
M src/posix.mak
M src/root/longdouble.c
M src/root/longdouble.h
M src/win32.mak
Log Message:
-----------
fix build breakage
</pre>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
dmd-internals mailing list
<a class="moz-txt-link-abbreviated" href="mailto:dmd-internals@puremagic.com">dmd-internals@puremagic.com</a>
<a class="moz-txt-link-freetext" href="http://lists.puremagic.com/mailman/listinfo/dmd-internals">http://lists.puremagic.com/mailman/listinfo/dmd-internals</a></pre>
</blockquote>
<br>
</body>
</html>