<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div class="">I’m responding a bit late to this, but I see that you wrote:</div><div class=""><br class=""></div><div class=""> "Any pull requests that make breaking language changes must be approved by Walter and Andrei”</div><div class=""><br class=""></div><div class="">Doesn’t that apply for non-breaking language changes as well? Perhaps not trivial things like adding a new __traits but I would think it applies to most language changes.</div><br class=""><div class="">
<div class=""><span style="orphans: 2; widows: 2;" class="">-- </span><br style="orphans: 2; widows: 2;" class=""><span style="orphans: 2; widows: 2;" class="">/Jacob Carlborg</span></div>
</div>
<br class=""><div><blockquote type="cite" class=""><div class="">On 2 jun 2015, at 01:06, Steven Schveighoffer via dmd-internals <<a href="mailto:dmd-internals@puremagic.com" class="">dmd-internals@puremagic.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><meta http-equiv="Content-Type" content="text/html charset=utf-8" class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div class=""><a href="http://wiki.dlang.org/Pull_Requests#Reviews" class="">http://wiki.dlang.org/Pull_Requests#Reviews</a></div><div class=""><br class=""></div>A question came up on a PR as to what happens when someone reviews a PR.<div class=""><br class=""></div><div class="">I looked and didn’t see the PR review process formalized, and so I wrote down what I thought is our current policy.</div><div class=""><br class=""></div><div class="">Please view and update as appropriate, I’m sure I’m not the authority on this :)</div><div class=""><br class=""></div><div class="">-Steve</div></div>_______________________________________________<br class="">dmd-internals mailing list<br class=""><a href="mailto:dmd-internals@puremagic.com" class="">dmd-internals@puremagic.com</a><br class="">http://lists.puremagic.com/mailman/listinfo/dmd-internals</div></blockquote></div><br class=""></body></html>