<div dir="auto"><div>I agree with striving to remove legacy code. <div dir="auto">The problem I see with the current solution is that there is no migration path. The preview switch has the appearance of an optional thing, but it isn't. Editing dmd/ldc2.conf is not a viable hard requirement in order to use plplot. <div dir="auto"><br></div><div dir="auto">The bigger problem that I see is that we are making D compilation compile flags even more awkward. The noXlinker option means the user has to pass to dmd a gcc option ("-Xlinker") in order to pass a flag to the linker....?! </div><div dir="auto"><br></div><div dir="auto">It's nice there is some sort of solution for the plplot issue. But I'm happy I don't have to implement and maintain the logic of figuring out in a cmake script which dmd version is used, or ldc, or gdc, or what flag is put in dmd.conf that changes cmdline behavior,............. </div><div dir="auto"><div dir="auto"><div dir="auto"><br></div><div dir="auto">-Johan </div></div></div></div><br><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Sep 26, 2019, 07:46 Mike Franklin via dmd-internals <<a href="mailto:dmd-internals@puremagic.com">dmd-internals@puremagic.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div class="m_-9153836727061624396ydp8e4b2acayahoo-style-wrap" style="font-family:Helvetica Neue,Helvetica,Arial,sans-serif;font-size:13px"><div></div>
<div dir="ltr">Johan,</div><div dir="ltr"><br></div><div dir="ltr">Yes, users opting into the option with `-preview=noXlinker` will need to fully opt into it. So it will be best for them to just add `-preview=noXlinker` and other adjustments to their dmd.conf file.</div><div dir="ltr"><br></div><div dir="ltr">The reason I chose not to implement `-Xcc` is because we have too many ways of doing the same thing. The code is becoming difficult to learn and maintain as we try to carry forward the design decisions of the past indefinitely. I'm sure you and others will disagree, but I think it is best to invest with the hope that someday we can delete legacy code, not continue to add to it.</div><div dir="ltr"><br></div><div dir="ltr">Mike<br></div><div><br></div>
</div><div id="m_-9153836727061624396yahoo_quoted_0157917142" class="m_-9153836727061624396yahoo_quoted">
<div style="font-family:'Helvetica Neue',Helvetica,Arial,sans-serif;font-size:13px;color:#26282a">
<div>
On Thursday, September 26, 2019, 2:39:16 PM GMT+9, Johan Engelen via dmd-internals <<a href="mailto:dmd-internals@puremagic.com" target="_blank" rel="noreferrer">dmd-internals@puremagic.com</a>> wrote:
</div>
<div><br></div>
<div><br></div>
<div><div id="m_-9153836727061624396yiv4128752368"><div><div dir="ltr"><div class="m_-9153836727061624396yiv4128752368yqt1235832742" id="m_-9153836727061624396yiv4128752368yqtfd39658"><div dir="ltr">On Thu, Sep 26, 2019 at 4:13 AM Alan W. Irwin via dmd-internals <<a rel="nofollow noreferrer" shape="rect" href="mailto:dmd-internals@puremagic.com" target="_blank">dmd-internals@puremagic.com</a>> wrote:<br clear="none"></div></div><div class="m_-9153836727061624396yiv4128752368gmail_quote"><blockquote class="m_-9153836727061624396yiv4128752368gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div class="m_-9153836727061624396yiv4128752368yqt1235832742" id="m_-9153836727061624396yiv4128752368yqtfd35766"><br clear="none">
I spoke too soon (sigh) about this new -preview=noXlinker option<br clear="none">
actually working, see <<a rel="nofollow noreferrer" shape="rect" href="https://issues.dlang.org/show_bug.cgi?id=20244" target="_blank">https://issues.dlang.org/show_bug.cgi?id=20244</a></div>>.<br clear="none"></blockquote><div><br clear="none"></div><div>Reading that bug report, it appears to me that this is not a simple "preview" option: dmd.conf may need adjustment and thus the user cannot simply switch between the option being on or off. Why not implement LDC's -Xcc as well?</div><div><br clear="none"></div><div>-Johan</div><div class="m_-9153836727061624396yiv4128752368yqt1235832742" id="m_-9153836727061624396yiv4128752368yqtfd69381"><div><br clear="none"></div><div><br clear="none"></div><div> </div></div></div></div></div></div><div class="m_-9153836727061624396yqt1235832742" id="m_-9153836727061624396yqtfd38584">_______________________________________________<br clear="none">dmd-internals mailing list<br clear="none"><a shape="rect" href="mailto:dmd-internals@puremagic.com" target="_blank" rel="noreferrer">dmd-internals@puremagic.com</a><br clear="none"><a shape="rect" href="http://lists.puremagic.com/mailman/listinfo/dmd-internals" target="_blank" rel="noreferrer">http://lists.puremagic.com/mailman/listinfo/dmd-internals</a></div></div>
</div>
</div></div>_______________________________________________<br>
dmd-internals mailing list<br>
<a href="mailto:dmd-internals@puremagic.com" target="_blank" rel="noreferrer">dmd-internals@puremagic.com</a><br>
<a href="http://lists.puremagic.com/mailman/listinfo/dmd-internals" rel="noreferrer noreferrer" target="_blank">http://lists.puremagic.com/mailman/listinfo/dmd-internals</a></blockquote></div></div></div>