[phobos] Commit 1717 broke Phobos unittests

Andrei Alexandrescu andrei at erdani.com
Fri Aug 6 08:54:15 PDT 2010


I'll take care of that today. I also plan to sort out all phobos issues 
and provide a clean build. I think I tracked down what was causing 
crashes earlier - pasing a "string literal" by ref compiles (it 
shouldn't) and generates erroneous code.

Andrei

Don Clugston wrote:
> conv.d, in the parse function for floating point numbers:
> Target parse(Target, Source)(ref Source p) if (isInputRange!Source &&
> /*!isSomeString!Source && */isFloatingPoint!Target)
> 
> The offending line is line 1360:
> enforce(anydigits);
> 
> This is wrong; it should be throwing ConvError. This makes the
> unittests in line 2257, 2312, 2380 fail.
> 
> In fact, most of the other uses of enforce() in this function should
> probably be throwing a ConvError.
> _______________________________________________
> phobos mailing list
> phobos at puremagic.com
> http://lists.puremagic.com/mailman/listinfo/phobos


More information about the phobos mailing list