[phobos] substring for std.metastrings
philippe.sigaud at gmail.com
Sun Feb 28 09:59:50 PST 2010
(hmm, first time post there. Hello, I'm mostly human and mostly harmless).
On Fri, Feb 26, 2010 at 11:45, Igor Lesik <curoles at yahoo.com> wrote:
> I believe, I have a function that is good candidate to be in
> Feedback is appreciated.
1- I guess that when t is the empty string you should return true, not
false: the empty string is present in any string. So your first static if
should be cut in two.
2- the .found necessary to get the result could be hidden with a two-levels
template substring(string s, string t)
enum bool substring = substringImpl!(s,t).found;
and rename your substring into substringImpl. Then you can do:
auto s = substring!("fun with gun", "run");
I don't know if you can put substringImpl as a private template inside
3- Maybe you could do a (string s, char c) version which casts the char into
a string and look for it.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the phobos