[phobos] datetime review

[Michel Fortin]

Le 2010-10-12 à 14:08, Jonathan M Davis a écrit :

> Except that most of the logic is going to be calendar-specific such that you 
> really don't gain much by trying to separate out the calendar-specific logic. 
> Date, DateTime, and SysTime all have a property to give you the Xth day since 
> the beginning of the Proleptic Gregorian Calendar (dayOfGregorianCal IIRC), and 
> SysTime has the stdTime property which gives you its internal representation of 
> hecto-nanoseconds (100 ns) since midnight January 1st, 1 AD UTC, so all of the 
> information necessary to convert to other calendar systems is there. But since 
> most of the operations on Date, DateTime, and SysTime are specific to the 
> Gregorian Calendar, I don't see much - if any - gain in trying to refactor out 
> the non-calendar-specific stuff.

Don't misunderstand: I don't see much gain either.

The main gain (in my opinion) would be that it could make the API cleaner, but you have to weight it against the inconveniences: it would involve a major refactoring.

I don't think it's necessary, it's just something that itches me.


-- 
Michel Fortin
michel.fortin at michelf.com
http://michelf.com/