[phobos] std.base64 replacement

Daniel Murphy yebblies at gmail.com
Tue Oct 26 07:41:52 PDT 2010


Looks awesome!

A couple of things:
> The output range code should use put(range, data) instead of
range.put(data)
> The whole static if at 1136 is dead code and refers to a variable that is
never declared
> The unittest block at 1471 doesn't compile for me, but this might be
because I'm still using 2.047
> The import comments should probably be replaced with true selective
imports (unless this is to work around the protection level bugs or
something)

Hope I haven't been too annoying,
Daniel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.puremagic.com/pipermail/phobos/attachments/20101027/35895d6b/attachment.html>


More information about the phobos mailing list