[phobos] [D-Programming-Language/phobos] ac0407: std.datetime fixed so that it doesn't need the day...

[Brad Roberts]

On 2/20/2011 2:27 AM, Jonathan M Davis wrote:
> 
> There are _multiple_ UTC time zone files for whatever reason. On Linux, all of 
> these files are identical:
> 
> /usr/share/zoneinfo/Etc/UTC
> /usr/share/zoneinfo/UTC
> /usr/share/zoneinfo/posix/Etc/UTC
> /usr/share/zoneinfo/posix/UTC
> 
> I don't know why there are so many. The time zone files could arguably be cleaned 
> up, because there are a number of them which are duplicates of one another (not 
> just UTC). The FreeBSD folks probably decided that there was no point in having 
> so many and didn't include some of them - kind of like how Mac OS X doesn have 
> have any of the time zone files which would be in /usr/share/zoneinfo/right. I 
> guess that this is just one more thing that goes to show that we'd benefit from 
> having an autotester on all of the platforms that we release for.
> 
> By the way, we may want to make sure that we leave a message on pull requests 
> when we merge them in, since it doesn't look like there's a way to determine who 
> merged in a pull request if they didn't have to make any additional changes to 
> it before they could push it into the main branch.
> 
> In this particular case, I assume that Brad did it, since he also made a change 
> to fix a test for FreeBSD in std.datetime, but I don't know that for sure. And if 
> for some reason I needed to contact whoever merged in a particular pull request, 
> I don't see any way to know who they are if they didn't comment on the pull 
> request or make any additional changes when doing the merge.
> 
> - Jonathan M Davis

On freebsd 8.1, the only UTC file is Etc/UTC, so rather little choice in the matter.

I did indeed do the merge, as can be seen from the news feed:

  https://github.com/organizations/D-Programming-Language

That's the only place I see it though, which is unfortunate.  It's also barely visible from the push email from github
to the phobos@ list.  I think it's worth filing an enhancement request with github to have who pushed it indicated in
the pull request.  It auto-closed it, so there's already some hook between the two.  I'll file it.

Later,
Brad