[phobos] lots of spurious code that doesn't work

Jonathan M Davis jmdavisProg at gmx.com
Fri Jan 21 22:24:59 PST 2011


On Friday 21 January 2011 22:17:17 Brad Roberts wrote:
> On 1/21/2011 9:41 PM, Andrei Alexandrescu wrote:
> > On 1/21/11 10:25 PM, Brad Roberts wrote:
> >> On Fri, 21 Jan 2011, Andrei Alexandrescu wrote:
> >>> On 1/21/11 8:56 PM, Brad Roberts wrote:
> >>>> What needs to be added to the auto-tester to catch this near submit
> >>>> time? Is it another make target?  If so, what?
> >>> 
> >>> It's make -f posix.mak html that fails on all systems.
> >> 
> >> Gah.. what the hell does it need wine for?  How twisted is that?  It
> >> only runs via the posix.mak file, but runs the windows binaries? 
> >> Please god, why?
> > 
> > Sorry, I meant "OSX and Linux" instead of "all systems". Wine is present
> > for two reasons:
> > 
> > 1. Allows people who don't use Windows to test on a Windows-like platform
> > 
> > 2. Is a good check for the portability of our Windows code across
> > different Windows versions.
> > 
> > But it's not required. Feel free to ignore it. Unless you say
> > OS=win32wine while building it won't bother you.
> 
> I said nothing more than:
> 
> make DMD=../../dmd/src/dmd DRUNTIME_PATH=../../druntime MODEL=64 -f
> posix.mak html
> 
> And got:
> wine dmd -version=ddoc -d -c -o- ../docsrc/std.ddoc -I../../druntime/import
> -Df../web/2.0/phobos/phobos.html phobos.d
> make: wine: Command not found
> 
> I'll dig in to see why I got that and not something saner after I dig into
> why the win32 dmd tests are failing.  I'm fairly sure it has to do with
> the replace changes still not working right.

When I build with make -f posix.html -version=ddoc, I get

----------

GNU Make 3.81
Copyright (C) 2006  Free Software Foundation, Inc.
This is free software; see the source for copying conditions.
There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A
PARTICULAR PURPOSE.

This program built for x86_64-unknown-linux-gnu

----------

So, I have no clue what's going on there. Something isn't working right, but 
whether it's the makefile or my system, I don't know.

However, I really do think that we should be set up to build the docs on both 
Linux and Windows natively, and that we should work on making the documentation 
in the code such that it's identical for every OS (though obviously, that will 
take some time). And having the docs build for both Linux and Windows on the 
autotester would be good to have as part of that, though obviously the build has 
to actually _work_ first.

- Jonathan M Davis


More information about the phobos mailing list