[phobos] [D-Programming-Language/phobos] a15e68: Accidentally committed with a bunch of debugging c...

[Steve Schveighoffer]

Guidelines for this would be nice to have.

I'd say definite changes that should go through a reviewed pull request:

* changes from non-phobos developers (obviously)
* changes to files that you do not "own" (even if trivial).  For example, if I were to find a bug in std.parallelism, I shouldn't commit, I should generate a pull request for review.

* changes that alter the design of a module.
* new code (including adding classes/structs/functions to an existing module)


I think everything else is OK to commit directly instead of generating a pull request, including bug fixes (as long as they are not fixed by doing one of the above).


What do you think?  A list like this (and actually, our entire process should be documented, including how to get included as a phobos developer) should be posted to the web site.

-Steve


>________________________________
>From: David Simcha <dsimcha at gmail.com>
>To: Discuss the phobos library for D <phobos at puremagic.com>
>Sent: Sunday, May 1, 2011 11:29 PM
>Subject: Re: [phobos] [D-Programming-Language/phobos] a15e68: Accidentally committed with a bunch of debugging c...
>
>On 5/1/2011 10:51 PM, Andrei Alexandrescu wrote:
>> David -- you may want to make updates through the pull request system. That gives you the opportunity of having one extra pair of eyes look over the code.
>> 
>> Ideally there should be at least two people involved in a change. Unfortunately, it looks like the second person is me rather often.
>> 
>
>I understand the idea that significant commits should be reviewed, but where do we draw the line?  Reviewing even the most trivial commits seems unnecessarily bureaucratic to me.  In the case of the initial commit, std.parallelism had already been in review for weeks.  (To play Devil's Advocate, though, the changes to the make file might have been worth reviewing.)
>_______________________________________________
>phobos mailing list
>phobos at puremagic.com
>http://lists.puremagic.com/mailman/listinfo/phobos
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.puremagic.com/pipermail/phobos/attachments/20110502/f5af88c3/attachment.html>