[phobos] [D-Programming-Language/phobos] 1b7db2: improvements/fixes for count countUntil

GitHub noreply at github.com
Thu Dec 13 09:17:50 PST 2012


  Branch: refs/heads/master
  Home:   https://github.com/D-Programming-Language/phobos
  Commit: 1b7db2de5eba6905ca3ac7deda236a5221b60f3d
      https://github.com/D-Programming-Language/phobos/commit/1b7db2de5eba6905ca3ac7deda236a5221b60f3d
  Author: unknown <monarchdodra at gmail.com>
  Date:   2012-11-17 (Sat, 17 Nov 2012)

  Changed paths:
    M std/algorithm.d

  Log Message:
  -----------
  improvements/fixes for count countUntil

Changes:

1. Count:
1.1 Better conditional statement
1.2 Count will now turn down any infinite haystacks (or else you'd count to infinity...)
1.3 Infinite needle will instantaneously return a count of 0.
1.4 Fixes a condition that was checking pred(haystack, needle), as opposed to pred(haystack.front, needle.front) (guess no one ever tried a fuzzy count?)
1.5 Fixes reference range support...*

2. countUntil:
2.1 Better conditional statement
2.2 countUntil supports InputRange for element and predicate search.
2.3 Fixes unicode bug (return the amount of popFronts, not index)
2.4 Fixes http://d.puremagic.com/issues/show_bug.cgi?id=8804
2.5 Fixes http://d.puremagic.com/issues/show_bug.cgi?id=8821

Note: count is still subject to the bugs in splitAfter
* Incorrect reference range support
* Incorrect split for forward range
Both are corrected in another pull.
As such, no unittests are added (yet).


  Commit: 3dffa6c47513aa2b4b47d20c96c4d42f2047a8d0
      https://github.com/D-Programming-Language/phobos/commit/3dffa6c47513aa2b4b47d20c96c4d42f2047a8d0
  Author: monarch dodra <monarchdodra at gmail.com>
  Date:   2012-11-20 (Tue, 20 Nov 2012)

  Changed paths:
    M std/algorithm.d

  Log Message:
  -----------
  more improvements in cout/countUntil


  Commit: a98a93f1e4bbc33a6decb6f6ab1118d4e240068a
      https://github.com/D-Programming-Language/phobos/commit/a98a93f1e4bbc33a6decb6f6ab1118d4e240068a
  Author: monarch dodra <monarchdodra at gmail.com>
  Date:   2012-11-20 (Tue, 20 Nov 2012)

  Changed paths:
    M std/path.d

  Log Message:
  -----------
  fixing countUntil vs indexOf issue


  Commit: 0a3b7be8e135e35c5a2d9ee4d665f769b6a66150
      https://github.com/D-Programming-Language/phobos/commit/0a3b7be8e135e35c5a2d9ee4d665f769b6a66150
  Author: monarch dodra <monarchdodra at gmail.com>
  Date:   2012-11-20 (Tue, 20 Nov 2012)

  Changed paths:
    M std/algorithm.d

  Log Message:
  -----------
  Quick splitter countUntil fix

This is more of a band-aid..., splitter needs some deep fixing anyways...


  Commit: 076c853b7389f8c81e0fa8130e0e0db073d38bad
      https://github.com/D-Programming-Language/phobos/commit/076c853b7389f8c81e0fa8130e0e0db073d38bad
  Author: monarch dodra <monarchdodra at gmail.com>
  Date:   2012-11-20 (Tue, 20 Nov 2012)

  Changed paths:
    M std/algorithm.d

  Log Message:
  -----------
  indexOf: More details

Not 100% about the text...


  Commit: 20d77cb8ffd60fe64dd044b58b9b5a54de29bbe2
      https://github.com/D-Programming-Language/phobos/commit/20d77cb8ffd60fe64dd044b58b9b5a54de29bbe2
  Author: monarch dodra <monarchdodra at gmail.com>
  Date:   2012-11-22 (Thu, 22 Nov 2012)

  Changed paths:
    M std/algorithm.d

  Log Message:
  -----------
  Changes to count[Until] as suggested by review


  Commit: 1b2b5fb76e7e7b0fc72e76e445ceba0cb83f3bc6
      https://github.com/D-Programming-Language/phobos/commit/1b2b5fb76e7e7b0fc72e76e445ceba0cb83f3bc6
  Author: Andrei Alexandrescu <andrei at erdani.com>
  Date:   2012-12-13 (Thu, 13 Dec 2012)

  Changed paths:
    M std/algorithm.d
    M std/path.d

  Log Message:
  -----------
  Merge pull request #951 from monarchdodra/count3

improvements/fixes for count countUntil


Compare: https://github.com/D-Programming-Language/phobos/compare/259cd23d67b8...1b2b5fb76e7e


More information about the phobos mailing list