[phobos] [D-Programming-Language/phobos] 6e5b1d: Changing ByCodepoint's "save" signature

GitHub noreply at github.com
Sun Dec 23 20:06:52 PST 2012


  Branch: refs/heads/master
  Home:   https://github.com/D-Programming-Language/phobos
  Commit: 6e5b1d0b922e242be17d5caff3b2c029beb0e8de
      https://github.com/D-Programming-Language/phobos/commit/6e5b1d0b922e242be17d5caff3b2c029beb0e8de
  Author: monarch dodra <monarchdodra at gmail.com>
  Date:   2012-12-12 (Wed, 12 Dec 2012)

  Changed paths:
    M std/internal/uni.d

  Log Message:
  -----------
  Changing ByCodepoint's "save" signature

1) Because if it returns a ref, then it isn't actually saving anything...
2) Changed the "const" qualifier to inout: Using "const" means the return type is always "const ByCodepoint", which isn't a valid range (a const range can't be popped)

The change is mostly moot, since it would appear ByCodepoint's save or forwardness is never used anyways. But that doesn't mean it shouldn't be correct.


  Commit: 540e84f214b18a0606c5fa14f3493af6d078c98e
      https://github.com/D-Programming-Language/phobos/commit/540e84f214b18a0606c5fa14f3493af6d078c98e
  Author: Andrei Alexandrescu <andrei at erdani.com>
  Date:   2012-12-23 (Sun, 23 Dec 2012)

  Changed paths:
    M std/internal/uni.d

  Log Message:
  -----------
  Merge pull request #1006 from monarchdodra/internalunisave

Changing ByCodepoint's "save" signature 


Compare: https://github.com/D-Programming-Language/phobos/compare/c1f8609e1fa6...540e84f214b1


More information about the phobos mailing list