[phobos] Pull request style

Walter Bright walter at digitalmars.com
Sat Feb 18 22:28:19 PST 2012



On 2/18/2012 9:53 PM, Daniel Murphy wrote:
> On Sun, Feb 19, 2012 at 16:46, Brad Roberts<braddr at puremagic.com>  wrote:
>> Currently they're not auto-closed, they're only auto-annotated with the pull requests.  The code for doing the
>> annotations and closes is a generic hook run by the guys at github and it has no way of doing any project specific logic.
>>
>> So, no.
> Damn.  I can't wait until we get to ditch D1 at the end of they year.
>
> Walter, do you want 'fix' on pulls for D2/D1 bugs?  If so I'll go
> through and add it to all of mine.
> _______________________________________________
>

At the moment it's not *really* necessary, since the hook for 'fix' isn't there 
yet, so as long as they have the "issue nnnn" they're ok. I'd just like this to 
be the style going forwards.


More information about the phobos mailing list