[phobos] Friendly reminder about pull requests

[Jonathan M Davis]

On Sunday, July 01, 2012 22:18:44 Andrei Alexandrescu wrote:
> One issue I'm having with reviewing: I can't seem to find a place to see
> the latest and greatest proposed code diff'ed against the extant code.
> Is there a possibility to do that? I can only see stuff changed by each
> individual diff, which is fine if I look for a specific change, but what
> I really want to review is everything proposed against everything current.

Well, the diff that you see when you click on diff in the pull request gives a 
diff in comparison to the commits prior to the changes being committed.  So, 
what you're looking for is being able to diff the state of all of Phobos in the 
pull request against the state of all of Phobos in the current master?

I believe that this explains how to do it:

https://github.com/blog/683-cross-repository-compare-view

Though I don't see how to actually _get_ to the compare view that they're 
describing without typing in the URL. For Kenji's repository, you'd type

https://github.com/9rnsr/phobos/compare/master

For mine you'd type

https://github.com/jmdavis/phobos/compare/master

and then you can manipulate the repository and branches being compared using 
the compare view.

Personally, I think that seeing all of that extra information is just 
distracting though.

- Jonathan M Davis