[phobos] Friendly reminder about pull requests

Jonathan M Davis jmdavisProg at gmx.com
Mon Jul 2 02:41:12 PDT 2012


On Monday, July 02, 2012 10:40:06 David Nadlinger wrote:
> On 2 Jul 2012, at 9:22, Jonathan M Davis wrote:
> > On Monday, July 02, 2012 09:04:14 David Nadlinger wrote:
> >> On 2 Jul 2012, at 7:11, Andrei Alexandrescu wrote:
> >> You also get this view by clicking the Diff tab at the top (along
> >> Discussion and Commits). I agree that is incredibly useful – not
> >> sure
> >> how you »survived« so far… ;)
> > 
> > That's different though. That shows the diff between the commit before
> > the pull
> > request and the last commit of the pull request. What Andrei seems to
> > want is
> > the diff between the last commit of the pull request and the latest
> > commit in
> > Phobos, which is very different, especially if the pull request has
> > been around
> > for a while and a lot of other stuff has been committed.
> 
> Ah, I see – but the link Andrei mentioned seems to point to exactly
> the same address as the "tab" at the top.

If that's the case, then it won't help him any.

Yeah, it looks like it just takes you to the diff tab. I don't know of an easy 
way to get to the comparison tool that I mentioned earlier. If you type in the 
URL directly, it works, but I don't see any easy way to click to it. Maybe it 
would be clearer if I read all of the article that I linked to, but it seemed 
to assume that you already knew how to get there.

- Jonathan M Davis


More information about the phobos mailing list