[phobos] [dmd-beta] Time for new beta

Alex Rønne Petersen xtzgzorex at gmail.com
Mon May 28 13:36:57 PDT 2012


> What's stopping us from handling all pull requests w/in a week?  Or even better a day or two?

I see two main causes:

1) Too few people in the community actually care enough to review pull requests.
2) Too few people have the necessary rights to actually merge pull requests.

I'm not sure how to rectify the former. The latter has an obvious solution.

See also the discussion on:


On Mon, May 28, 2012 at 10:07 PM, Brad Roberts <braddr at puremagic.com> wrote:
> There's an analogy that we like to use at work, and in my experience it holds pretty well for code quality and bleeds
> pretty well into the entire development process:
>  http://en.wikipedia.org/wiki/Broken_windows_theory
> We do an ok job when it comes to the tests (though certainly not perfect).  We've been getting a lot better at
> addressing regressions, though there's still 4 open right now (1 phobos, 2 druntime, 1 dmd).  Can we please make the
> remaining open regressions a release blocker?
> Also, I'd really love to see the pull lists knocked down considerably before the next beta, particularly the phobos set
> (considering the larger set of people with access to it).  The d-p-l and tools sets should be even easier to keep at 0,
> but even those have some accumulated requests, the oldest of which is over a year now.
> Several of the open requests (across all the repos) are open because there's some controversy about them.  I'll pick the
> 'dur' ones as a good, but hardly only, example.  Either those should be pulled or closed.  Leaving in limbo helps no
> one.  For this sort of request, a choice needs to be made and move on.  A key part of the problem with this set is that
> we don't have a process for deciding what to do with them.  Anyone care to put forth a proposal?
> Another example is the const(Object)ref code change.  There's little value in the pull request being open for a year.
> Closing the pull request does NOT do anything irrevocable as the branch remains available (assuming the author doesn't
> delete it).  Keeping it open doesn't help with anything other than maybe loosing track of it, but that's better done
> through bugzilla, imho.  Closing it wouldn't be a rejection, but a long term deferral.
> What's stopping us from handling all pull requests w/in a week?  Or even better a day or two?
> My 2 cents,
> Brad
> On 5/28/2012 1:41 AM, Walter Bright wrote:
>> Since I'll be out next week, I think that would be a good time to do a beta. So, let's aim towards getting a beta
>> release ready by Saturday.
>> -Walter
>> _______________________________________________
>> dmd-beta mailing list
>> dmd-beta at puremagic.com
>> http://lists.puremagic.com/mailman/listinfo/dmd-beta
> _______________________________________________
> phobos mailing list
> phobos at puremagic.com
> http://lists.puremagic.com/mailman/listinfo/phobos

More information about the phobos mailing list