[phobos] [D-Programming-Language/phobos] cf22dc: Uncomment unwanted overload of Socket.select.

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/D-Programming-Language/phobos
  Commit: cf22dc636a7a69113f4935eef980c21db791e0bd
      https://github.com/D-Programming-Language/phobos/commit/cf22dc636a7a69113f4935eef980c21db791e0bd
  Author: jmdavis <jmdavisProg at gmx.com>
  Date:   2012-11-16 (Fri, 16 Nov 2012)

  Changed paths:
    M std/socket.d

  Log Message:
  -----------
  Uncomment unwanted overload of Socket.select.

_No_ D function in druntime or Phobos should be taking time values as
naked integral values. I thought that we'd caught them all, but
Socket.select still has such an overload unfortunately. Given that we're
trying not to break anything right now and deprecated still triggers
errors rather than warnings, I simply uncommented that overload for now.
That way, new code won't use it. We may or may not actually deprecate it
later.

I'm not particularly enthused about the TimeVal type existing in
std.socket either, since it's just duplicating core.time.Duration's
functionality, but I'm not going to try and get rid of it right now.
However, I _did_ move select's Duration overload so that it was first
with the idea that that would increase the odds of people using that
one instead. No functionality should have changed in this commit.


  Commit: 93c7f8ecdbe3a788625a9a59b97238a67a17cbd4
      https://github.com/D-Programming-Language/phobos/commit/93c7f8ecdbe3a788625a9a59b97238a67a17cbd4
  Author: Alex Rønne Petersen <alex at lycus.org>
  Date:   2012-11-16 (Fri, 16 Nov 2012)

  Changed paths:
    M std/socket.d

  Log Message:
  -----------
  Merge pull request #955 from jmdavis/socket

Uncomment unwanted overload of Socket.select.


Compare: https://github.com/D-Programming-Language/phobos/compare/90e9bfee9de8...93c7f8ecdbe3