[phobos] [D-Programming-Language/phobos] 0adb95: Make conv unittest private simbols private

GitHub noreply at github.com
Wed Jun 19 17:33:54 PDT 2013


  Branch: refs/heads/master
  Home:   https://github.com/D-Programming-Language/phobos
  Commit: 0adb9524d60d0bef48a43c7b09f8ac067da4e238
      https://github.com/D-Programming-Language/phobos/commit/0adb9524d60d0bef48a43c7b09f8ac067da4e238
  Author: monarch dodra <monarchdodra at gmail.com>
  Date:   2013-06-19 (Wed, 19 Jun 2013)

  Changed paths:
    M std/conv.d

  Log Message:
  -----------
  Make conv unittest private simbols private

There were some symbols in a "version(unittest)" block that were not declared private.

This can create some conflicts during unittest releases. I started out just declaring them private, but that created some ambiguities in other modules that used "A" in their names, eg:
```D
struct Appender(A : T[], T)
```

`std\array.d(2129): Error: module std.array std.conv.A is private`.

So I just mangled the names. As a workaround. I'll file a bug report later.


  Commit: 9eccf5d2e7c1d8f25681c36e7f15068c3dc33dd5
      https://github.com/D-Programming-Language/phobos/commit/9eccf5d2e7c1d8f25681c36e7f15068c3dc33dd5
  Author: Hara Kenji <k.hara.pg+dev at gmail.com>
  Date:   2013-06-19 (Wed, 19 Jun 2013)

  Changed paths:
    M std/conv.d

  Log Message:
  -----------
  Merge pull request #1349 from monarchdodra/privateConv

Make conv unittest private simbols private


Compare: https://github.com/D-Programming-Language/phobos/compare/631e27674051...9eccf5d2e7c1


More information about the phobos mailing list