[phobos] [D-Programming-Language/phobos] 02fe8a: Ensure adequate code coverage from std.random.Rand...

GitHub noreply at github.com
Sat Jun 29 07:21:43 PDT 2013


  Branch: refs/heads/master
  Home:   https://github.com/D-Programming-Language/phobos
  Commit: 02fe8ad76af8d666b7cec01dfad5a95184e2bf7e
      https://github.com/D-Programming-Language/phobos/commit/02fe8ad76af8d666b7cec01dfad5a95184e2bf7e
  Author: Joseph Rushton Wakeling <joe at webdrake.net>
  Date:   2013-06-20 (Thu, 20 Jun 2013)

  Changed paths:
    M std/random.d

  Log Message:
  -----------
  Ensure adequate code coverage from std.random.RandomSample unittests.

The old unittests were missing coverage of large sections of
RandomSample.skip() because the ratios of sample size to source size
were such that Algorithm A was always being chosen over Algorithm D.

The new unittests fix this and also extend coverage to a number of
other areas previously not addressed.  There are also currently-failing
tests commented out with version(none) that can be used to verify
future bugfixes and improvements.

A few lines in skip() remain uncovered simply because they depend on
runtime conditions that are extremely rare.


  Commit: fddc91d5c3d02624120d430006a5267911c1419d
      https://github.com/D-Programming-Language/phobos/commit/fddc91d5c3d02624120d430006a5267911c1419d
  Author: Joseph Rushton Wakeling <joe at webdrake.net>
  Date:   2013-06-20 (Thu, 20 Jun 2013)

  Changed paths:
    M std/random.d

  Log Message:
  -----------
  Complete code coverage for Xorshift unittests.

Unittests for Xorshift were previously failing to cover the
constructor, and the .seed(), .save and .opEquals() methods.


  Commit: 037ec6e3d1301f0701538d8b1c10c9eaf6e85678
      https://github.com/D-Programming-Language/phobos/commit/037ec6e3d1301f0701538d8b1c10c9eaf6e85678
  Author: Joseph Rushton Wakeling <joe at webdrake.net>
  Date:   2013-06-20 (Thu, 20 Jun 2013)

  Changed paths:
    M std/random.d

  Log Message:
  -----------
  Complete non-static code coverage for LinearCongruentialEngine unittests.

Unittests for LinearCongruentialEngine were previously missing the
constructor and the .save and .opEquals() methods.

Code coverage analysis still fails to pick up on the static methods
and the contents of a static if scope in lines 374-382 of .popFront().


  Commit: 0d5162b82600ed32774677481aa91cf9addf577b
      https://github.com/D-Programming-Language/phobos/commit/0d5162b82600ed32774677481aa91cf9addf577b
  Author: Joseph Rushton Wakeling <joe at webdrake.net>
  Date:   2013-06-20 (Thu, 20 Jun 2013)

  Changed paths:
    M std/random.d

  Log Message:
  -----------
  Unittest for MersenneTwisterEngine .save.


  Commit: 66cc47b3c1c8894deae64c7d503dede08aae1943
      https://github.com/D-Programming-Language/phobos/commit/66cc47b3c1c8894deae64c7d503dede08aae1943
  Author: Joseph Rushton Wakeling <joe at webdrake.net>
  Date:   2013-06-20 (Thu, 20 Jun 2013)

  Changed paths:
    M std/random.d

  Log Message:
  -----------
  Remove superflous assert(false) and return statements.


  Commit: da1dfefba165ffd99afa5b9647b6f94d26cb2951
      https://github.com/D-Programming-Language/phobos/commit/da1dfefba165ffd99afa5b9647b6f94d26cb2951
  Author: Joseph Rushton Wakeling <joe at webdrake.net>
  Date:   2013-06-21 (Fri, 21 Jun 2013)

  Changed paths:
    M std/random.d

  Log Message:
  -----------
  Many asserts in std.random can be made static.


  Commit: b135fe92931ac7319999a0f291e69cdfa1cb381c
      https://github.com/D-Programming-Language/phobos/commit/b135fe92931ac7319999a0f291e69cdfa1cb381c
  Author: Andrej Mitrovic <andrej.mitrovich at gmail.com>
  Date:   2013-06-29 (Sat, 29 Jun 2013)

  Changed paths:
    M std/random.d

  Log Message:
  -----------
  Merge pull request #1357 from WebDrake/random-testcoverage

 Issue 10426 - Improve code coverage of std.random unittests


Compare: https://github.com/D-Programming-Language/phobos/compare/4da1639c98cb...b135fe92931a


More information about the phobos mailing list