[phobos] [D-Programming-Language/phobos] a34861: [10116] stdio.File.byLine repeats last line foreve...

GitHub noreply at github.com
Sun May 19 15:16:48 PDT 2013


  Branch: refs/heads/master
  Home:   https://github.com/D-Programming-Language/phobos
  Commit: a34861d80c703ece67cf45ae15a1ac19febf7ae0
      https://github.com/D-Programming-Language/phobos/commit/a34861d80c703ece67cf45ae15a1ac19febf7ae0
  Author: Frank van Dijk <fwvdijk at gmail.com>
  Date:   2013-05-19 (Sun, 19 May 2013)

  Changed paths:
    M std/stdio.d

  Log Message:
  -----------
  [10116] stdio.File.byLine repeats last line forever, readln(ref C[],R) returns bad data

byLine expects readln to return with an empty buffer on end-of-stream,
which readln does not do for wchar and dchar. Also, the readln variant
that takes a terminator range returns incorrect concatenations of
lines because of the same issue. Fixed by setting buffer.length=0 in
readln for this case. Unit test updated to detect this issue.


  Commit: 14a4b923e76ab914e1e623cf1f3caddddc72469f
      https://github.com/D-Programming-Language/phobos/commit/14a4b923e76ab914e1e623cf1f3caddddc72469f
  Author: Andrei Alexandrescu <andrei at erdani.com>
  Date:   2013-05-19 (Sun, 19 May 2013)

  Changed paths:
    M std/stdio.d

  Log Message:
  -----------
  Merge pull request #1295 from M-frankied/byLine-infloop

[10116] stdio.File.byLine repeats last line forever, readln(ref C[],R) r...


Compare: https://github.com/D-Programming-Language/phobos/compare/a1ae5ceac81e...14a4b923e76a


More information about the phobos mailing list