[phobos] [dlang/phobos] c35d4a: Fix issue 14137: std.socket.getAddressInfo breaks ...

GitHub via phobos phobos at puremagic.com
Mon Apr 18 06:51:40 PDT 2016


  Branch: refs/heads/master
  Home:   https://github.com/dlang/phobos
  Commit: c35d4aa26efd0907ccb48d7406dffc50f470971c
      https://github.com/dlang/phobos/commit/c35d4aa26efd0907ccb48d7406dffc50f470971c
  Author: H. S. Teoh <hsteoh at quickfur.ath.cx>
  Date:   2016-02-17 (Wed, 17 Feb 2016)

  Changed paths:
    M std/socket.d

  Log Message:
  -----------
  Fix issue 14137: std.socket.getAddressInfo breaks @safe

Remove abuse of @trusted in template function getAddressInfo that cannot
guarantee that the incoming type argument is @safe. Localize @trusted
block of the function to the single call to getAddressInfoImpl(), so
that any @system code in T will be caught by the type system.

Add unittest to ensure such examples of T will be rejected at
compile-time.

Mark normal unittest for getAddressInfo as @safe to ensure that the
function body itself does not introduce any non- at safe code.


  Commit: 8a3453129f57a9db19c15026d184fc4e9da18ac3
      https://github.com/dlang/phobos/commit/8a3453129f57a9db19c15026d184fc4e9da18ac3
  Author: Dmitry Olshansky <dmitry.olsh at gmail.com>
  Date:   2016-04-18 (Mon, 18 Apr 2016)

  Changed paths:
    M std/socket.d

  Log Message:
  -----------
  Merge pull request #4009 from quickfur/issue14137

Fix issue 14137: std.socket.getAddressInfo breaks @safe


Compare: https://github.com/dlang/phobos/compare/1f37557e38b7...8a3453129f57


More information about the phobos mailing list