Should we put a separate alwaysAssert() function into Phobos that does output the line number and file, and then remove this from enforce()? I see two use cases for enforce: As a function that asserts even in release mode, and for real error handling.<br>
<br>I tend to use enforce in a lot of places where I would otherwise use assert, but want to leave the check on in release mode. I find that I very frequently don't want every array access bounds checked or expensive asserts checked, but still want the asserts that have negligible performance cost to be checked even in release mode. However, using enforce() like this sometimes devalues it for "real" error handling because you can't catch the exception it throws without possibly catching what's logically an assert error.<br>
<br><div class="gmail_quote">On Thu, Jul 1, 2010 at 1:15 PM, Steve Schveighoffer <span dir="ltr"><<a href="mailto:schveiguy@yahoo.com">schveiguy@yahoo.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
User: your application exited with an error message<br>
Developer: What was the message?<br>
User: Need nonnegative i<br>
Developer: Well, don't pass in a negative i then!<br>
<div class="im"><br>
:)<br>
<br>
-Steve<br>
<br>
<br>
<br>
----- Original Message ----<br>
> From: Lars Tandle Kyllingstad <<a href="mailto:lars@kyllingen.net">lars@kyllingen.net</a>><br>
</div><div><div></div><div class="h5">> To: Discuss the phobos library for D <<a href="mailto:phobos@puremagic.com">phobos@puremagic.com</a>><br>
> Sent: Thu, July 1, 2010 10:15:36 AM<br>
> Subject: Re: [phobos] enforce() improvement<br>
><br>
> The library user would still get the information,<br>
> because<br>
Throwable.toString() would still give the file and line number, and<br>
> like<br>
I said, Throwable.file and Throwable.line are supposed to be filled<br>
> with<br>
that information. My point was that enforce() puts the information<br>
> in<br>
Throwable.msg, which I find completely redundant.<br>
<br>
Also, if you are<br>
> using plain enforce() for error checking (like Phobos<br>
does in a lot of<br>
> places), Throwable.msg is your only source of<br>
information to pass to the<br>
> user, since enforce() by default throws an<br>
Exception and not an<br>
> InsightfulInformationException.<br>
<br>
-Lars<br>
<br>
<br>
<br>
On Thu, 2010-07-01<br>
> at 07:00 -0700, Steve Schveighoffer wrote:<br>
> I disagree. The "user"<br>
> in this case, is the user of the library code. He does in fact need to<br>
> know the file/line that caused the problem, and more useful would be the full<br>
> stack trace so he can see where his code used the offending value.<br>
><br>
><br>
> If you are relying on enforce to give insightful error messages to an<br>
> actual user (that is, someone who runs your program), then you need some<br>
> training in user interface design :)<br>
><br>
> -Steve<br>
><br>
><br>
><br>
><br>
> ----- Original Message ----<br>
> > From: Lars Tandle<br>
> Kyllingstad <<br>
</div></div><div class="im">> href="mailto:<a href="mailto:lars@kyllingen.net">lars@kyllingen.net</a>"><a href="mailto:lars@kyllingen.net">lars@kyllingen.net</a>><br>
> > To:<br>
> Phobos mailing list <<br>
</div><div><div></div><div class="h5">> href="mailto:<a href="mailto:phobos@puremagic.com">phobos@puremagic.com</a>"><a href="mailto:phobos@puremagic.com">phobos@puremagic.com</a>><br>
> ><br>
> Sent: Thu, July 1, 2010 9:50:15 AM<br>
> > Subject: [phobos] enforce()<br>
> improvement<br>
> ><br>
> > Often, at least in small programs, when<br>
> an exception is thrown you just<br>
> want<br>
> > to present a sensible<br>
> message to the user and abort the<br>
> > current<br>
> operation.<br>
> Example:<br>
><br>
> void<br>
> ><br>
> doStuff(int i) { enforce(i >= 0, "Need nonnegative i"); }<br>
><br>
><br>
><br>
> > try<br>
> doStuff(-1);<br>
> catch<br>
> > (Exception<br>
> e) writeln("Error: ", e.msg);<br>
><br>
> In this case, the user will<br>
><br>
> > see<br>
><br>
> Error: b.d(5):<br>
> Need nonnegative<br>
> > i<br>
><br>
> My point is that the user<br>
> doesn't need to see the file and line<br>
> > number<br>
> that caused<br>
> the error. This is only useful for the<br>
> > programmer. So<br>
> I<br>
> suggest we make either of the following changes to<br>
> ><br>
> enforce():<br>
><br>
> 1. Drop the file and line number<br>
> from the<br>
> > message. The Throwable<br>
><br>
> class has dedicated<br>
> > 'file' and 'line' fields which we<br>
> can<br>
> populate<br>
> > with that<br>
> information without polluting the error<br>
><br>
><br>
> > message.<br>
> 2. Another option is to<br>
> include the file and line<br>
> > only in debug<br>
><br>
> builds.<br>
><br>
> -Lars<br>
> ><br>
><br>
><br>
><br>
> _______________________________________________<br>
> phobos mailing<br>
><br>
> > list<br>
><br>
> > href="mailto:<br>
</div></div>> ymailto="mailto:<a href="mailto:phobos@puremagic.com">phobos@puremagic.com</a>"<br>
<div class="im">> href="mailto:<a href="mailto:phobos@puremagic.com">phobos@puremagic.com</a>"><a href="mailto:phobos@puremagic.com">phobos@puremagic.com</a>"><br>
</div>> ymailto="mailto:<a href="mailto:phobos@puremagic.com">phobos@puremagic.com</a>"<br>
<div class="im">> href="mailto:<a href="mailto:phobos@puremagic.com">phobos@puremagic.com</a>"><a href="mailto:phobos@puremagic.com">phobos@puremagic.com</a><br>
><br>
> <a href="http://lists.puremagic.com/mailman/listinfo/phobos" target="_blank">http://lists.puremagic.com/mailman/listinfo/phobos</a><br>
><br>
><br>
><br>
><br>
><br>
> _______________________________________________<br>
> phobos mailing<br>
> list<br>
><br>
> href="mailto:<a href="mailto:phobos@puremagic.com">phobos@puremagic.com</a>"><a href="mailto:phobos@puremagic.com">phobos@puremagic.com</a><br>
><br>
</div>> href="<a href="http://lists.puremagic.com/mailman/listinfo/phobos" target="_blank">http://lists.puremagic.com/mailman/listinfo/phobos</a>" target=_blank<br>
<div class="im">> ><a href="http://lists.puremagic.com/mailman/listinfo/phobos" target="_blank">http://lists.puremagic.com/mailman/listinfo/phobos</a><br>
<br>
<br>
_______________________________________________<br>
phobos<br>
> mailing list<br>
<br>
> href="mailto:<a href="mailto:phobos@puremagic.com">phobos@puremagic.com</a>"><a href="mailto:phobos@puremagic.com">phobos@puremagic.com</a><br>
<br>
</div>> href="<a href="http://lists.puremagic.com/mailman/listinfo/phobos" target="_blank">http://lists.puremagic.com/mailman/listinfo/phobos</a>" target=_blank<br>
<div><div></div><div class="h5">> ><a href="http://lists.puremagic.com/mailman/listinfo/phobos" target="_blank">http://lists.puremagic.com/mailman/listinfo/phobos</a><br>
<br>
<br>
<br>
_______________________________________________<br>
phobos mailing list<br>
<a href="mailto:phobos@puremagic.com">phobos@puremagic.com</a><br>
<a href="http://lists.puremagic.com/mailman/listinfo/phobos" target="_blank">http://lists.puremagic.com/mailman/listinfo/phobos</a><br>
</div></div></blockquote></div><br>