<html><body bgcolor="#FFFFFF"><div>Thanks for this initiative - of which I see you already implemented a good amount!<br><br>Sent by shouting through my showerhead.</div><div><br>On Jun 23, 2010, at 10:36 AM, David Simcha <<a href="mailto:dsimcha@gmail.com">dsimcha@gmail.com</a>> wrote:<br><br></div><div></div><blockquote type="cite"><div>Ok, so I'll probably have time soon to do a serous cleanup of all these nagging @property and auto ref issues and improve the unittests in std.range and std.algorithm, across everything, not just the couple ranges that I worked on recently. I'm sick enough of all these little nagging issues that make ranges hard to use in D that I'm willing to devote some significant effort towards solving them. Before I do, do we all agree on the following:<br>
<br>1. All higher order ranges should use auto ref.<br>2. front(), empty(), back(), length() and save() are @property.<br>3. popFront(), popBack(), and moveFront() are <u><i><b>NOT</b></i></u> @property.<br>4. Higher order ranges should check for infinite-ness of the ranges they're operating on and propagate it (using enum bool empty = false instead of a function that propagates empty) where it makes sense, for example in Map and Filter.<br>
<br>If so, these standards should be published somewhere to discourage the kind of inconsistency that's developed due to sheer confusion about what the "right" answers to these issues are.<br><br><div class="gmail_quote">
On Wed, Jun 23, 2010 at 1:20 PM, Max Samukha <span dir="ltr"><<a href="mailto:maxsamukha@gmail.com"><a href="mailto:maxsamukha@gmail.com">maxsamukha@gmail.com</a></a>></span> wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<br><br><div class="gmail_quote"><div class="im">On Wed, Jun 23, 2010 at 5:01 PM, David Simcha <span dir="ltr"><<a href="mailto:dsimcha@gmail.com" target="_blank"><a href="mailto:dsimcha@gmail.com">dsimcha@gmail.com</a></a>></span> wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
Isn't that the point of @property? I just followed what Andrei was doing. If there's anywhere where I didn't put @property in, it's purely an unintentional oversight. Please let me know and/or fix it.<br>
<br></blockquote></div><div>I don't have commit access to phobos. DummyRange.front on line 1644 and DummyRange.save (1647) should be properties, I believe. Also, 'front' on line 1553.<br></div></div><br>
<br>_______________________________________________<br>
phobos mailing list<br>
<a href="mailto:phobos@puremagic.com"><a href="mailto:phobos@puremagic.com">phobos@puremagic.com</a></a><br>
<a href="http://lists.puremagic.com/mailman/listinfo/phobos" target="_blank"><a href="http://lists.puremagic.com/mailman/listinfo/phobos">http://lists.puremagic.com/mailman/listinfo/phobos</a></a><br></blockquote></div><br>
</div></blockquote><blockquote type="cite"><div><span>_______________________________________________</span><br><span>phobos mailing list</span><br><span><a href="mailto:phobos@puremagic.com">phobos@puremagic.com</a></span><br><span><a href="http://lists.puremagic.com/mailman/listinfo/phobos">http://lists.puremagic.com/mailman/listinfo/phobos</a></span></div></blockquote></body></html>