<html><body><div style="color:#000; background-color:#fff; font-family:arial, helvetica, sans-serif;font-size:12pt"><div><span>Are you so sure someone would *always* notice this? This seems like an error that should be caught by automatic testing (<span class="yshortcuts" id="lw_1305639806_0">unit test</span>).<br></span></div><div><br><span></span></div><div><span>I think with reviews, we are looking for subtle or <span class="yshortcuts" id="lw_1305639806_1">logic errors</span>,
not obvious blow-up ones. This was just a simple mistake, and that
shit happens. I don't think anyone said that people would check in
bug-free code to the master branch.<br></span></div><div><br></div><div>Note the time between the initial checkin and the fix, this was not a significant issue.</div><div><br></div>-Steve<div><br><blockquote style="border-left: 2px solid rgb(16, 16, 255); margin-left: 5px; padding-left: 5px;"><div style="font-family: arial, helvetica, sans-serif; font-size: 12pt;"><div style="font-family: times new roman, new york, times, serif; font-size: 12pt;"><font face="Arial" size="2"><hr size="1"><b><span style="font-weight:bold;">From:</span></b> andralex <reply+c-386425-2aecf1b7f6afda42be20f0fedb55f7b83b33cb7f@reply.github.com><br><b><span style="font-weight: bold;">To:</span></b> schveiguy@yahoo.com<br><b><span style="font-weight: bold;">Sent:</span></b> Tuesday, May 17, 2011 12:49 AM<br><b><span style="font-weight: bold;">Subject:</span></b> Re: [phobos] Argh, how did I leave that main block in there by accident? (de572e9)<br></font><br>
The onus is always on the committer to have run the unit tests.<br><br>-- <br>Reply to this email directly or view it on GitHub:<br><a href="https://github.com/D-Programming-Language/phobos/commit/de572e9b131d1e66f23886815d9911313995f144#commitcomment-386425" target="_blank">https://github.com/D-Programming-Language/phobos/commit/de572e9b131d1e66f23886815d9911313995f144#commitcomment-386425</a><br><br><br></div></div></blockquote></div></div></body></html>