<div dir="ltr">Ok. It's on the list and hopefully have time to work on it in a couple of weeks.</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, Jun 3, 2013 at 2:45 AM, Jonathan M Davis <span dir="ltr"><<a href="mailto:jmdavisProg@gmx.com" target="_blank">jmdavisProg@gmx.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im">On Monday, June 03, 2013 02:38:33 Daniel Murphy wrote:<br>
> IIRC this is the "import blah;" vs "import blah : *" that we discussed at<br>
> the conference.<br>
<br>
</div>It's not. It works just fine when importing something like std.datetime.all<br>
which publicly imports the package, but with your changes, the public imports<br>
in package.d don't allow std.datetime.DosFileTime to work, unlike with<br>
std.datetime.all. To quote my comment in the pull request:<br>
<br>
-----------------<br>
I don't think that this is a problem with the proposal that this is trying to<br>
implement. I think that the problem is in the implementation. Note that using<br>
a public selective import didn't work either, and both aliasing and selective<br>
importing std.datetime.common.DosFileTime in std.datetime.package should have<br>
worked, even if simply publicly importing std.datetime.common didn't. Also, if<br>
I create three modules like so:<br>
<br>
a.d<br>
<br>
int i = 7;<br>
b.d<br>
<br>
public import a;<br>
c.d<br>
<br>
import std.stdio;<br>
import b;<br>
<br>
void main()<br>
{<br>
writeln(b.i);<br>
}<br>
the code compiles and prints 7. Module c is able to use b.i as if i were in b<br>
when in fact it's in a. So, the public importing itself does what we want for<br>
this proposal.<br>
<br>
I don't think that there's necessarily anything wrong with the proposal that<br>
this pull request is trying to implement. It would work if you were trying to<br>
import std.datetime.all. and then use std.datetime.all.DosFileTime. I think<br>
that the problem has to be in how the implementation translates<br>
std.datetime.package into std.datetime. Clearly, specifying the full import<br>
path doesn't work with it even though it works with public imports normally.<br>
-----------------<br>
<div class="im"><br>
> I can't remember what our resolution for that is, so I'll<br>
> have another go when I do. And when I'm done with DAC. And I finish<br>
> exams. And I finish the DMD -> D port. etc Haven't given up, just no time.<br>
<br>
</div>Well, life happens. I'm plenty busy as well. I just figured that I'd ask, since<br>
you never responded to my comment in the pull request, and I wasn't sure<br>
whether you'd read it or not.<br>
<div class="HOEnZb"><div class="h5"><br>
- Jonathan M Davis<br>
_______________________________________________<br>
phobos mailing list<br>
<a href="mailto:phobos@puremagic.com">phobos@puremagic.com</a><br>
<a href="http://lists.puremagic.com/mailman/listinfo/phobos" target="_blank">http://lists.puremagic.com/mailman/listinfo/phobos</a><br>
</div></div></blockquote></div><br></div>